feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Mark some virtual overrides final

Browse Source 
These methods are being called from c'tor or from d'tor.
Make sure these methods will not get overridden by any possible
subclass, otherwise these calls won't be dispatched properly.

Change-Id: I3652d2f495940f13b48b494ab2cf06abb3d37e7e
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Jarek Kobus
2022-12-07 18:35:11 +01:00
parent 42bc552f2b
commit 8e7e1dd5f2
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/plugins/coreplugin/actionmanager/actioncontainer_p.h
View File

@@ -28,19 +28,19 @@ public:
ActionContainerPrivate(Utils::Id id);
~ActionContainerPrivate() override = default;
void setOnAllDisabledBehavior(OnAllDisabledBehavior behavior) override;
ActionContainer::OnAllDisabledBehavior onAllDisabledBehavior() const override;
void setOnAllDisabledBehavior(OnAllDisabledBehavior behavior) final;
ActionContainer::OnAllDisabledBehavior onAllDisabledBehavior() const final;
QAction *insertLocation(Utils::Id groupId) const override;
void appendGroup(Utils::Id id) override;
void insertGroup(Utils::Id before, Utils::Id groupId) override;
void addAction(Command *action, Utils::Id group = {}) override;
void addMenu(ActionContainer *menu, Utils::Id group = {}) override;
void addMenu(ActionContainer *before, ActionContainer *menu) override;
Command *addSeparator(const Context &context, Utils::Id group = {}, QAction **outSeparator = nullptr) override;
void clear() override;
QAction *insertLocation(Utils::Id groupId) const final;
void appendGroup(Utils::Id id) final;
void insertGroup(Utils::Id before, Utils::Id groupId) final;
void addAction(Command *action, Utils::Id group = {}) final;
void addMenu(ActionContainer *menu, Utils::Id group = {}) final;
void addMenu(ActionContainer *before, ActionContainer *menu) final;
Command *addSeparator(const Context &context, Utils::Id group = {}, QAction **outSeparator = nullptr) final;
void clear() final;
Utils::Id id() const override;
Utils::Id id() const final;
QMenu *menu() const override;
QMenuBar *menuBar() const override;

2
src/plugins/docker/dockerdevice.cpp
View File

@@ -202,7 +202,7 @@ public:
private:
void start() override;
qint64 write(const QByteArray &data) override;
void sendControlSignal(ControlSignal controlSignal) override;
void sendControlSignal(ControlSignal controlSignal) final;
private:
DockerDevicePrivate *m_devicePrivate = nullptr;