From 8e8236e9e00a6df27ef4632e8fb7cc20cd70e5e8 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Thu, 15 Apr 2021 15:39:18 +0200 Subject: [PATCH] CppEditor: Add missing template arguments ... in "Add Virtual Methods From Base Class" quickfix. Fixes: QTCREATORBUG-25589 Change-Id: I5ffef27acf151422ec4f56d48451e263664bfc2d Reviewed-by: Christian Stenger --- src/plugins/cppeditor/cppinsertvirtualmethods.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/plugins/cppeditor/cppinsertvirtualmethods.cpp b/src/plugins/cppeditor/cppinsertvirtualmethods.cpp index 6a6743d7b3c..862c185d268 100644 --- a/src/plugins/cppeditor/cppinsertvirtualmethods.cpp +++ b/src/plugins/cppeditor/cppinsertvirtualmethods.cpp @@ -783,6 +783,7 @@ public: printer.showFunctionSignatures = true; printer.showReturnTypes = true; printer.showArgumentNames = true; + printer.showTemplateParameters = true; Utils::ChangeSet headerChangeSet; const CppRefactoringChanges refactoring(snapshot()); const QString filename = currentFile()->fileName(); @@ -1906,7 +1907,7 @@ void CppEditorPlugin::test_quickfix_InsertVirtualMethods_implementationFile() original = "class BaseA {\n" "public:\n" - " virtual int a() = 0;\n" + " virtual int a(const std::vector &v) = 0;\n" "};\n\n" "class Derived : public Bas@eA {\n" "public:\n" @@ -1915,7 +1916,7 @@ void CppEditorPlugin::test_quickfix_InsertVirtualMethods_implementationFile() expected = "class BaseA {\n" "public:\n" - " virtual int a() = 0;\n" + " virtual int a(const std::vector &v) = 0;\n" "};\n\n" "class Derived : public BaseA {\n" "public:\n" @@ -1923,7 +1924,7 @@ void CppEditorPlugin::test_quickfix_InsertVirtualMethods_implementationFile() "\n" " // BaseA interface\n" "public:\n" - " virtual int a();\n" + " virtual int a(const std::vector &v);\n" "};\n"; testFiles << Tests::QuickFixTestDocument::create("file.h", original, expected); @@ -1932,7 +1933,7 @@ void CppEditorPlugin::test_quickfix_InsertVirtualMethods_implementationFile() expected = "#include \"file.h\"\n" "\n\n" - "int Derived::a()\n" + "int Derived::a(const std::vector &v)\n" "{\n}"; testFiles << Tests::QuickFixTestDocument::create("file.cpp", original, expected);