feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: More cleanup in the drag tool

Browse Source 
Change-Id: I52cf75ec558b6f59b731abdca2bbebafb527f181
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>
This commit is contained in:
Marco Bubke
2014-07-21 18:06:07 +02:00
parent ac7f17c28a
commit 8e9bb26143
2 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/qmldesigner/components/formeditor/dragtool.cpp
View File

@@ -123,12 +123,12 @@ void DragTool::beginWithPoint(const QPointF &beginPoint)
void DragTool::createQmlItemNode(const ItemLibraryEntry &itemLibraryEntry, void DragTool::createQmlItemNode(const ItemLibraryEntry &itemLibraryEntry,
const QmlItemNode &parentNode, const QmlItemNode &parentNode,
const QPointF &scenePos) const QPointF &scenePosition)
{ {
MetaInfo metaInfo = MetaInfo::global(); MetaInfo metaInfo = MetaInfo::global();
FormEditorItem *parentItem = scene()->itemForQmlItemNode(parentNode); FormEditorItem *parentItem = scene()->itemForQmlItemNode(parentNode);
QPointF pos = parentItem->mapFromScene(scenePos); QPointF pos = parentItem->mapFromScene(scenePosition);
m_dragNode = QmlItemNode::createQmlItemNode(view(), itemLibraryEntry, pos, parentNode); m_dragNode = QmlItemNode::createQmlItemNode(view(), itemLibraryEntry, pos, parentNode);
@@ -139,15 +139,15 @@ void DragTool::createQmlItemNode(const ItemLibraryEntry &itemLibraryEntry,
void DragTool::createQmlItemNodeFromImage(const QString &imageName, void DragTool::createQmlItemNodeFromImage(const QString &imageName,
const QmlItemNode &parentNode, const QmlItemNode &parentNode,
const QPointF &scenePos) const QPointF &scenePosition)
{ {
if (parentNode.isValid()) { if (parentNode.isValid()) {
MetaInfo metaInfo = MetaInfo::global(); MetaInfo metaInfo = MetaInfo::global();
FormEditorItem *parentItem = scene()->itemForQmlItemNode(parentNode); FormEditorItem *parentItem = scene()->itemForQmlItemNode(parentNode);
QPointF pos = parentItem->mapFromScene(scenePos); QPointF positonInItemSpace = parentItem->qmlItemNode().instanceSceneTransform().inverted().map(scenePosition);
m_dragNode = QmlItemNode::createQmlItemNodeFromImage(view(), imageName, pos, parentNode); m_dragNode = QmlItemNode::createQmlItemNodeFromImage(view(), imageName, positonInItemSpace, parentNode);
QList<QmlItemNode> nodeList; QList<QmlItemNode> nodeList;
nodeList.append(m_dragNode); nodeList.append(m_dragNode);
@@ -355,7 +355,7 @@ void DragTool::end(Snapper::Snapping useSnapping)
clear(); clear();
} }
void DragTool::move(const QPointF &scenePos, const QList<QGraphicsItem*> &itemList) void DragTool::move(const QPointF &scenePosition, const QList<QGraphicsItem*> &itemList)
{ {
if (m_movingItem) { if (m_movingItem) {
FormEditorItem *containerItem = targetContainerOrRootItem(itemList, m_movingItem.data()); FormEditorItem *containerItem = targetContainerOrRootItem(itemList, m_movingItem.data());
@@ -367,7 +367,7 @@ void DragTool::move(const QPointF &scenePos, const QList<QGraphicsItem*> &itemL
Snapper::Snapping useSnapping = Snapper::UseSnapping; Snapper::Snapping useSnapping = Snapper::UseSnapping;
m_moveManipulator.update(scenePos, useSnapping, MoveManipulator::UseBaseState); m_moveManipulator.update(scenePosition, useSnapping, MoveManipulator::UseBaseState);
} }
} }

2
src/plugins/qmldesigner/components/formeditor/dragtool.h
View File

@@ -73,8 +73,6 @@ public:
void beginWithPoint(const QPointF &beginPoint); void beginWithPoint(const QPointF &beginPoint);
//void beginWithPoint(const QPointF &beginPoint);
void clear() QTC_OVERRIDE; void clear() QTC_OVERRIDE;
void formEditorItemsChanged(const QList<FormEditorItem*> &itemList) QTC_OVERRIDE; void formEditorItemsChanged(const QList<FormEditorItem*> &itemList) QTC_OVERRIDE;