feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Port from qAsConst() to std::as_const()

Browse Source 
We've been requiring C++17 since Qt 6.0, and our qAsConst use finally
starts to bother us (QTBUG-99313), so time to port away from it
now.

Since qAsConst has exactly the same semantics as std::as_const (down
to rvalue treatment, constexpr'ness and noexcept'ness), there's really
nothing more to it than a global search-and-replace.

Task-number: QTBUG-99313
Change-Id: I88edd91395849574436299b8badda21bb93bea39
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Marc Mutz
2022-10-07 14:46:06 +02:00
parent 90de29d530
commit 8eb4d52342
498 changed files with 1270 additions and 1270 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/coreplugin/dialogs/readonlyfilesdialog.cpp
View File

@@ -108,7 +108,7 @@ ReadOnlyFilesDialogPrivate::ReadOnlyFilesDialogPrivate(ReadOnlyFilesDialog *pare
ReadOnlyFilesDialogPrivate::~ReadOnlyFilesDialogPrivate()
{
for (const ButtonGroupForFile &groupForFile : qAsConst(buttonGroups))
for (const ButtonGroupForFile &groupForFile : std::as_const(buttonGroups))
delete groupForFile.group;
}
@@ -282,7 +282,7 @@ int ReadOnlyFilesDialog::exec()
ReadOnlyResult result = RO_Cancel;
FilePaths failedToMakeWritable;
for (const ReadOnlyFilesDialogPrivate::ButtonGroupForFile &buttongroup
: qAsConst(d->buttonGroups)) {
: std::as_const(d->buttonGroups)) {
result = static_cast<ReadOnlyResult>(buttongroup.group->checkedId());
switch (result) {
case RO_MakeWritable:
@@ -356,7 +356,7 @@ void ReadOnlyFilesDialogPrivate::setAll(int index)
// Check for every file if the selected operation is available and change it to the operation.
for (const ReadOnlyFilesDialogPrivate::ButtonGroupForFile &groupForFile :
qAsConst(buttonGroups)) {
std::as_const(buttonGroups)) {
auto radioButton = qobject_cast<QRadioButton *>(groupForFile.group->button(type));
if (radioButton)
radioButton->setChecked(true);
@@ -372,7 +372,7 @@ void ReadOnlyFilesDialogPrivate::updateSelectAll()
{
int selectedOperation = -1;
for (const ReadOnlyFilesDialogPrivate::ButtonGroupForFile &groupForFile :
qAsConst(buttonGroups)) {
std::as_const(buttonGroups)) {
if (selectedOperation == -1) {
selectedOperation = groupForFile.group->checkedId();
} else if (selectedOperation != groupForFile.group->checkedId()) {