feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Port from qAsConst() to std::as_const()

Browse Source 
We've been requiring C++17 since Qt 6.0, and our qAsConst use finally
starts to bother us (QTBUG-99313), so time to port away from it
now.

Since qAsConst has exactly the same semantics as std::as_const (down
to rvalue treatment, constexpr'ness and noexcept'ness), there's really
nothing more to it than a global search-and-replace.

Task-number: QTBUG-99313
Change-Id: I88edd91395849574436299b8badda21bb93bea39
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Marc Mutz
2022-10-07 14:46:06 +02:00
parent 90de29d530
commit 8eb4d52342
498 changed files with 1270 additions and 1270 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/languageclient/languageclientmanager.cpp
View File

@@ -186,7 +186,7 @@ void LanguageClientManager::addExclusiveRequest(const MessageId &id, Client *cli
void LanguageClientManager::reportFinished(const MessageId &id, Client *byClient)
{
QTC_ASSERT(managerInstance, return);
for (Client *client : qAsConst(managerInstance->m_exclusiveRequests[id])) {
for (Client *client : std::as_const(managerInstance->m_exclusiveRequests[id])) {
if (client != byClient)
client->cancelRequest(id);
}
@@ -275,14 +275,14 @@ void LanguageClientManager::applySettings()
documents << managerInstance->m_clientForDocument.keys(client);
shutdownClient(client);
}
for (auto document : qAsConst(documents))
for (auto document : std::as_const(documents))
managerInstance->m_clientForDocument.remove(document);
if (!setting->isValid() || !setting->m_enabled)
continue;
switch (setting->m_startBehavior) {
case BaseSettings::AlwaysOn: {
Client *client = startClient(setting);
for (TextEditor::TextDocument *document : qAsConst(documents))
for (TextEditor::TextDocument *document : std::as_const(documents))
managerInstance->m_clientForDocument[document] = client;
break;
}
@@ -296,7 +296,7 @@ void LanguageClientManager::applySettings()
}
if (!documents.isEmpty()) {
Client *client = startClient(setting);
for (TextEditor::TextDocument *document : qAsConst(documents))
for (TextEditor::TextDocument *document : std::as_const(documents))
client->openDocument(document);
}
break;
@@ -514,7 +514,7 @@ void LanguageClientManager::documentOpened(Core::IDocument *document)
} else if (setting->m_startBehavior == BaseSettings::RequiresFile && clients.isEmpty()) {
clients << startClient(setting);
}
for (auto client : qAsConst(clients))
for (auto client : std::as_const(clients))
client->openDocument(textDocument);
}
}
@@ -546,7 +546,7 @@ void LanguageClientManager::documentWillSave(Core::IDocument *document)
void LanguageClientManager::updateProject(ProjectExplorer::Project *project)
{
for (BaseSettings *setting : qAsConst(m_currentSettings)) {
for (BaseSettings *setting : std::as_const(m_currentSettings)) {
if (setting->isValid()
&& setting->m_enabled
&& setting->m_startBehavior == BaseSettings::RequiresProject) {