feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Port from qAsConst() to std::as_const()

Browse Source 
We've been requiring C++17 since Qt 6.0, and our qAsConst use finally
starts to bother us (QTBUG-99313), so time to port away from it
now.

Since qAsConst has exactly the same semantics as std::as_const (down
to rvalue treatment, constexpr'ness and noexcept'ness), there's really
nothing more to it than a global search-and-replace.

Task-number: QTBUG-99313
Change-Id: I88edd91395849574436299b8badda21bb93bea39
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Marc Mutz
2022-10-07 14:46:06 +02:00
parent 90de29d530
commit 8eb4d52342
498 changed files with 1270 additions and 1270 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/marketplace/productlistmodel.cpp
View File

@@ -308,7 +308,7 @@ void SectionedProducts::fetchNextImage()
if (QPixmapCache::find(nextUrl, nullptr)) {
// this image is already cached it might have been added while downloading
for (ProductListModel *model : qAsConst(m_productModels))
for (ProductListModel *model : std::as_const(m_productModels))
model->updateModelIndexesForUrl(nextUrl);
fetchNextImage();
return;
@@ -337,7 +337,7 @@ void SectionedProducts::onImageDownloadFinished(QNetworkReply *reply)
Qt::KeepAspectRatio, Qt::SmoothTransformation);
pixmap.setDevicePixelRatio(dpr);
QPixmapCache::insert(url, pixmap);
for (ProductListModel *model : qAsConst(m_productModels))
for (ProductListModel *model : std::as_const(m_productModels))
model->updateModelIndexesForUrl(url);
}
} // handle error not needed - it's okay'ish to have no images as long as the rest works
@@ -386,7 +386,7 @@ void SectionedProducts::onTagClicked(const QString &tag)
QList<Core::ListItem *> SectionedProducts::items()
{
QList<Core::ListItem *> result;
for (const ProductListModel *model : qAsConst(m_productModels))
for (const ProductListModel *model : std::as_const(m_productModels))
result.append(model->items());
return result;
}