feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Port from qAsConst() to std::as_const()

Browse Source 
We've been requiring C++17 since Qt 6.0, and our qAsConst use finally
starts to bother us (QTBUG-99313), so time to port away from it
now.

Since qAsConst has exactly the same semantics as std::as_const (down
to rvalue treatment, constexpr'ness and noexcept'ness), there's really
nothing more to it than a global search-and-replace.

Task-number: QTBUG-99313
Change-Id: I88edd91395849574436299b8badda21bb93bea39
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Marc Mutz
2022-10-07 14:46:06 +02:00
parent 90de29d530
commit 8eb4d52342
498 changed files with 1270 additions and 1270 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/projectexplorer/jsonwizard/jsonfieldpage.cpp
View File

@@ -1391,7 +1391,7 @@ bool JsonFieldPage::isComplete() const
bool result = true;
bool hasErrorMessage = false;
for (Field *f : qAsConst(m_fields)) {
for (Field *f : std::as_const(m_fields)) {
f->adjustState(m_expander);
if (!f->validate(m_expander, &message)) {
if (!message.isEmpty()) {
@@ -1411,19 +1411,19 @@ bool JsonFieldPage::isComplete() const
void JsonFieldPage::initializePage()
{
for (Field *f : qAsConst(m_fields))
for (Field *f : std::as_const(m_fields))
f->initialize(m_expander);
}
void JsonFieldPage::cleanupPage()
{
for (Field *f : qAsConst(m_fields))
for (Field *f : std::as_const(m_fields))
f->cleanup(m_expander);
}
bool JsonFieldPage::validatePage()
{
for (Field * const f : qAsConst(m_fields))
for (Field * const f : std::as_const(m_fields))
if (!f->persistenceKey().isEmpty() && f->hasUserChanges()) {
const QVariant value = f->toSettings();
if (value.isValid())