feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Port from qAsConst() to std::as_const()

Browse Source 
We've been requiring C++17 since Qt 6.0, and our qAsConst use finally
starts to bother us (QTBUG-99313), so time to port away from it
now.

Since qAsConst has exactly the same semantics as std::as_const (down
to rvalue treatment, constexpr'ness and noexcept'ness), there's really
nothing more to it than a global search-and-replace.

Task-number: QTBUG-99313
Change-Id: I88edd91395849574436299b8badda21bb93bea39
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Marc Mutz
2022-10-07 14:46:06 +02:00
parent 90de29d530
commit 8eb4d52342
498 changed files with 1270 additions and 1270 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/vcsbase/submitfieldwidget.cpp
View File

@@ -185,7 +185,7 @@ void SubmitFieldWidget::setHasBrowseButton(bool on)
if (d->hasBrowseButton == on)
return;
d->hasBrowseButton = on;
for (const FieldEntry &fe : qAsConst(d->fieldEntries))
for (const FieldEntry &fe : std::as_const(d->fieldEntries))
fe.browseButton->setVisible(on);
}
@@ -209,7 +209,7 @@ void SubmitFieldWidget::setCompleter(QCompleter *c)
if (c == d->completer)
return;
d->completer = c;
for (const FieldEntry &fe : qAsConst(d->fieldEntries))
for (const FieldEntry &fe : std::as_const(d->fieldEntries))
fe.lineEdit->setCompleter(c);
}
@@ -229,7 +229,7 @@ QString SubmitFieldWidget::fieldValues() const
const QChar newLine = QLatin1Char('\n');
// Format as "RevBy: value\nSigned-Off: value\n"
QString rc;
for (const FieldEntry &fe : qAsConst(d->fieldEntries)) {
for (const FieldEntry &fe : std::as_const(d->fieldEntries)) {
const QString value = fe.lineEdit->text().trimmed();
if (!value.isEmpty()) {
rc += fe.combo->currentText();