From 900007e781348d75fe1b8ebd61ac024e16c96074 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Tue, 17 Nov 2020 14:26:08 +0100 Subject: [PATCH] Reuse the requestExpansion() signal from the base class In addition correct the signatures of signals in BaseTreeModel. Change-Id: I8c49105c9fcc1a6115c5e5c0dc8d9e87ff98d707 Reviewed-by: hjk --- src/libs/utils/treemodel.h | 4 ++-- src/plugins/autotest/testresultspane.cpp | 2 +- src/plugins/projectexplorer/projectmodels.h | 1 - 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/libs/utils/treemodel.h b/src/libs/utils/treemodel.h index 7ab043032a6..2baa60e3878 100644 --- a/src/libs/utils/treemodel.h +++ b/src/libs/utils/treemodel.h @@ -207,8 +207,8 @@ protected: void destroyItem(TreeItem *item); // item is destroyed. signals: - void requestExpansion(QModelIndex); - void requestCollapse(QModelIndex); + void requestExpansion(const QModelIndex &); + void requestCollapse(const QModelIndex &); protected: friend class TreeItem; diff --git a/src/plugins/autotest/testresultspane.cpp b/src/plugins/autotest/testresultspane.cpp index 8a6ef9022d6..a95044c5225 100644 --- a/src/plugins/autotest/testresultspane.cpp +++ b/src/plugins/autotest/testresultspane.cpp @@ -152,7 +152,7 @@ TestResultsPane::TestResultsPane(QObject *parent) : connect(m_treeView, &ResultsTreeView::copyShortcutTriggered, [this] () { onCopyItemTriggered(getTestResult(m_treeView->currentIndex())); }); - connect(m_model, &TestResultModel::requestExpansion, [this] (QModelIndex idx) { + connect(m_model, &TestResultModel::requestExpansion, [this] (const QModelIndex &idx) { m_treeView->expand(m_filterModel->mapFromSource(idx)); }); connect(TestRunner::instance(), &TestRunner::testRunStarted, diff --git a/src/plugins/projectexplorer/projectmodels.h b/src/plugins/projectexplorer/projectmodels.h index 835e28993d6..b92a2471b97 100644 --- a/src/plugins/projectexplorer/projectmodels.h +++ b/src/plugins/projectexplorer/projectmodels.h @@ -92,7 +92,6 @@ public: signals: void renamed(const Utils::FilePath &oldName, const Utils::FilePath &newName); - void requestExpansion(const QModelIndex &index); private: bool m_filterProjects = false;