Core: Don't save settings on startup anymore

Amends a68352f013.

This is getting in the way, it does not look needed, and it is lost
in history why it ever was.

Change-Id: I68ebdafc78e3259c73c64364607aef6eb74d2869
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

src/plugins/coreplugin/icore.cpp

@@ -192,9 +192,7 @@ ICore::ICore(MainWindow *mainwindow)
 {
     m_instance = this;
     m_mainwindow = mainwindow;
-    // Save settings once after all plugins are initialized:
-    connect(PluginManager::instance(), &PluginManager::initializationDone,
-            this, [] { ICore::saveSettings(ICore::InitializationDone); });
+
     connect(PluginManager::instance(), &PluginManager::testsFinished,
             this, [this](int failedTests) {
         emit coreAboutToClose();

src/plugins/coreplugin/icore.h

@@ -117,7 +117,6 @@ public:
     static void restart();
 
     enum SaveSettingsReason {
-        InitializationDone,
         SettingsDialogDone,
         ModeChanged,
         MainWindowClosing,