From 9031ad19c4c662c719cd3012b41a64dfdfe8b31a Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Tue, 2 Jun 2020 15:54:59 +0200 Subject: [PATCH] StudioWelcome: Remove unused code and fix return value The connection to visibleChanged of the main window doesn't do anything, since its visibility doesn't change as long as the splash screen is showing. Also return false from delayedInitialize() if it doesn't do anything. Returning true requests that the next plugin's delayedInitialize() is actually delayed, which doesn't make sense it didn't do anything. Change-Id: I96793ce6df517bf37b3b060e80daf8cc74d71247 Reviewed-by: Thomas Hartmann --- src/plugins/studiowelcome/studiowelcomeplugin.cpp | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/plugins/studiowelcome/studiowelcomeplugin.cpp b/src/plugins/studiowelcome/studiowelcomeplugin.cpp index abdecb1180b..b382bf1c760 100644 --- a/src/plugins/studiowelcome/studiowelcomeplugin.cpp +++ b/src/plugins/studiowelcome/studiowelcomeplugin.cpp @@ -259,21 +259,11 @@ void StudioWelcomePlugin::extensionsInitialized() bool StudioWelcomePlugin::delayedInitialize() { if (s_view.isNull()) - return true; + return false; QTC_ASSERT(s_view->rootObject() , return true); s_view->rootObject()->setProperty("loadingPlugins", false); - - QPointer view = s_view; - - connect(Core::ICore::mainWindow()->windowHandle(), &QWindow::visibleChanged, this, [view](){ - if (!view.isNull()) { - view->close(); - view->deleteLater(); - } - }); - return false; }