From 90500b0225bde1dfd33f4888314adaae28a8b267 Mon Sep 17 00:00:00 2001 From: Marco Bubke Date: Mon, 6 Jul 2015 14:44:25 +0200 Subject: [PATCH] Clang: Rename originalItem in codeCompletion Actually it is quite slow anyway to cast the variant to the value. Change-Id: Ied18208455adf9d7d5eb500e139170ced597dc1c Reviewed-by: Nikolai Kosjar --- src/plugins/clangcodemodel/clangassistproposalitem.cpp | 6 +++--- src/plugins/clangcodemodel/clangassistproposalitem.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/plugins/clangcodemodel/clangassistproposalitem.cpp b/src/plugins/clangcodemodel/clangassistproposalitem.cpp index 8c2ab1dc7ad..697e5453bb6 100644 --- a/src/plugins/clangcodemodel/clangassistproposalitem.cpp +++ b/src/plugins/clangcodemodel/clangassistproposalitem.cpp @@ -53,7 +53,7 @@ bool ClangAssistProposalItem::prematurelyApplies(const QChar &typedChar) const applies = (typedChar == QLatin1Char('/')) && text().endsWith(QLatin1Char('/')); else if (!isCodeCompletion()) applies = (typedChar == QLatin1Char('(')); /* && data().canConvert()*/ //### - else if (originalItem().completionKind() == CodeCompletion::ObjCMessageCompletionKind) + else if (codeCompletion().completionKind() == CodeCompletion::ObjCMessageCompletionKind) applies = QString::fromLatin1(";.,").contains(typedChar); else applies = QString::fromLatin1(";.,:(").contains(typedChar); @@ -67,7 +67,7 @@ bool ClangAssistProposalItem::prematurelyApplies(const QChar &typedChar) const void ClangAssistProposalItem::applyContextualContent(TextEditor::TextEditorWidget *editorWidget, int basePosition) const { - const CodeCompletion ccr = originalItem(); + const CodeCompletion ccr = codeCompletion(); QString toInsert = text(); QString extraChars; @@ -206,7 +206,7 @@ void ClangAssistProposalItem::addOverload(const CodeCompletion &ccr) m_overloads.append(ccr); } -CodeCompletion ClangAssistProposalItem::originalItem() const +CodeCompletion ClangAssistProposalItem::codeCompletion() const { const QVariant &value = data(); if (value.canConvert()) diff --git a/src/plugins/clangcodemodel/clangassistproposalitem.h b/src/plugins/clangcodemodel/clangassistproposalitem.h index 45cdd646526..b636f6d81b0 100644 --- a/src/plugins/clangcodemodel/clangassistproposalitem.h +++ b/src/plugins/clangcodemodel/clangassistproposalitem.h @@ -52,7 +52,7 @@ public: bool isOverloaded() const; void addOverload(const ClangBackEnd::CodeCompletion &ccr); - ClangBackEnd::CodeCompletion originalItem() const; + ClangBackEnd::CodeCompletion codeCompletion() const; bool isCodeCompletion() const; private: