feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Core: Prepare de-virtualization of IContext::contextHelp

Browse Source 
... by providing a way to specify modified implementation
by setting a functor.

Change-Id: Ib0907dd00fdb2ef15242a7ec2e25a5f8a9cc6979
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
hjk
2024-07-05 11:37:24 +02:00
parent 4992a686e8
commit 90e0cd4912
2 changed files with 22 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/plugins/coreplugin/icontext.cpp
View File

@@ -9,6 +9,24 @@
namespace Core {
void IContext::contextHelp(const HelpCallback &callback) const
{
if (m_contextHelpProvider) {
m_contextHelpProvider(callback);
} else {
// This is important as this triggers the continued iteration
// through other contexts that may provide items.
callback({});
}
}
void IContext::setContextHelp(const HelpItem &item)
{
m_contextHelpProvider = [item](const HelpCallback &callback) {
callback(item);
};
}
void IContext::attach(QWidget *widget, const Context &context, const HelpItem &help)
{
auto icontext = new IContext(widget); // As QObject parent.

7
src/plugins/coreplugin/icontext.h
View File

@@ -60,9 +60,10 @@ public:
void setContext(const Context &context) { m_context = context; }
using HelpCallback = std::function<void(const HelpItem &item)>;
virtual void contextHelp(const HelpCallback &callback) const { callback(m_contextHelp); }
using HelpProvider = std::function<void(const HelpCallback &item)>;
virtual void setContextHelp(const HelpItem &id) { m_contextHelp = id; }
virtual void contextHelp(const HelpCallback &callback) const;
void setContextHelp(const HelpItem &id);
static void attach(QWidget *widget,
const Context &context,
@@ -71,7 +72,7 @@ public:
protected:
Context m_context;
QPointer<QWidget> m_widget;
HelpItem m_contextHelp;
HelpProvider m_contextHelpProvider;
};
} // namespace Core