feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Make setDisplayName easier and break displayName signals

Browse Source 
Fix for that will come later
This commit is contained in:
dt
2009-11-26 15:53:38 +01:00
parent 801e9948f5
commit 9119853283
9 changed files with 9 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/plugins/projectexplorer/buildsettingspropertiespage.cpp
View File

@@ -200,8 +200,7 @@ BuildSettingsWidget::BuildSettingsWidget(Project *project)
connect(m_removeButton, SIGNAL(clicked()),
this, SLOT(deleteConfiguration()));
connect(m_project, SIGNAL(buildConfigurationDisplayNameChanged(ProjectExplorer::BuildConfiguration *)),
this, SLOT(buildConfigurationDisplayNameChanged(ProjectExplorer::BuildConfiguration *)));
// TODO update on displayNameChange
connect(m_project, SIGNAL(activeBuildConfigurationChanged()),
this, SLOT(checkMakeActiveLabel()));
@@ -231,17 +230,6 @@ void BuildSettingsWidget::updateAddButtonMenu()
}
}
void BuildSettingsWidget::buildConfigurationDisplayNameChanged(BuildConfiguration *bc)
{
for (int i=0; i<m_buildConfigurationComboBox->count(); ++i) {
if (m_buildConfigurationComboBox->itemData(i).value<BuildConfiguration *>() == bc) {
m_buildConfigurationComboBox->setItemText(i, bc->displayName());
break;
}
}
}
void BuildSettingsWidget::updateBuildSettings()
{
// TODO save position, entry from combbox
@@ -350,7 +338,7 @@ void BuildSettingsWidget::cloneConfiguration(BuildConfiguration *sourceConfigura
newDisplayName = Project::makeUnique(newDisplayName, buildConfigurationDisplayNames);
m_buildConfiguration = m_project->buildConfigurationFactory()->clone(sourceConfiguration);
m_project->setDisplayNameFor(m_buildConfiguration, newDisplayName);
m_buildConfiguration->setDisplayName(newDisplayName);
updateBuildSettings();
}