From 91208c827f1e796b54137c64bc4c32a9c9e161c2 Mon Sep 17 00:00:00 2001 From: Erik Verbruggen Date: Mon, 27 Sep 2010 17:59:12 +0200 Subject: [PATCH] C++: Disabled CompleteSwitchCaseStatement: needs bugfixing. (cherry picked from commit 3ff803d7e2543b64358755702d3c74318bc01736) --- src/plugins/cppeditor/cppquickfixes.cpp | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/plugins/cppeditor/cppquickfixes.cpp b/src/plugins/cppeditor/cppquickfixes.cpp index 9434dcf0555..c2f648a6cec 100644 --- a/src/plugins/cppeditor/cppquickfixes.cpp +++ b/src/plugins/cppeditor/cppquickfixes.cpp @@ -1338,6 +1338,13 @@ protected: const QList results = typeOfExpression(statement->condition, state.document(), scope); + + /// + /// \note FIXME: the lookup has at least two problems: the result.declaration() + /// will often be null, (i.e. when the condition is a function call) + /// and the lookups will not look through typedefs. + /// + foreach (LookupItem result, results) { FullySpecifiedType fst = result.type(); if (! result.declaration()) @@ -1741,9 +1748,11 @@ void CppQuickFixCollector::registerQuickFixes(ExtensionSystem::IPlugin *plugIn) plugIn->addAutoReleasedObject(new TranslateStringLiteral); plugIn->addAutoReleasedObject(new CStringToNSString); plugIn->addAutoReleasedObject(new ConvertNumericLiteral); - plugIn->addAutoReleasedObject(new CompleteSwitchCaseStatement); +// Disabled for now: see the CompleteSwitchCaseStatement class for the reason. +// plugIn->addAutoReleasedObject(new CompleteSwitchCaseStatement); plugIn->addAutoReleasedObject(new FixForwardDeclarationOp); plugIn->addAutoReleasedObject(new AddLocalDeclarationOp); plugIn->addAutoReleasedObject(new ToCamelCaseConverter); plugIn->addAutoReleasedObject(new Internal::DeclFromDef); + plugIn->addAutoReleasedObject(new Internal::DefFromDecl); }