feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Make aspect settings access implicit

Browse Source 
Generally, aspects should use fromMap/toMap, but some older pages
use {from,to}Settings with always the same ICore::settings().

To make that less intrusive on the user code side, make that globally
implicit.

Task-number: QTCREATORBUG-29167
Change-Id: I29a8e23a31eb8061bb143e93931a07c6741eb7f9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2023-07-06 09:57:16 +02:00
parent 9f1b56e91a
commit 91513a53dd
37 changed files with 111 additions and 123 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/autotest/testframeworkmanager.cpp
View File

@@ -9,8 +9,6 @@
#include <utils/algorithm.h>
#include <utils/qtcassert.h>
#include <QSettings>
using namespace Utils;
namespace Autotest {
@@ -95,16 +93,16 @@ ITestTool *TestFrameworkManager::testToolForBuildSystemId(Id buildSystemId)
});
}
void TestFrameworkManager::synchronizeSettings(QSettings *s)
void TestFrameworkManager::synchronizeSettings()
{
Internal::TestSettings::instance()->fromSettings(s);
Internal::TestSettings::instance()->fromSettings();
for (ITestFramework *framework : std::as_const(m_registeredFrameworks)) {
if (ITestSettings *fSettings = framework->testSettings())
fSettings->readSettings(s);
fSettings->readSettings();
}
for (ITestTool *testTool : std::as_const(m_registeredTestTools)) {
if (ITestSettings *tSettings = testTool->testSettings())
tSettings->readSettings(s);
tSettings->readSettings();
}
}