Utils: Make aspect settings access implicit

Generally, aspects should use fromMap/toMap, but some older pages
use {from,to}Settings with always the same ICore::settings().

To make that less intrusive on the user code side, make that globally
implicit.

Task-number: QTCREATORBUG-29167
Change-Id: I29a8e23a31eb8061bb143e93931a07c6741eb7f9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2023-07-06 09:57:16 +02:00
parent 9f1b56e91a
commit 91513a53dd
37 changed files with 111 additions and 123 deletions

View File

@@ -10,7 +10,6 @@
#include "testsettings.h"
#include "testtreemodel.h"
#include <coreplugin/icore.h>
#include <utils/algorithm.h>
#include <utils/id.h>
#include <utils/infolabel.h>
@@ -137,7 +136,7 @@ TestSettingsWidget::TestSettingsWidget()
testSettings(s);
testToolsSettings(s);
s.toSettings(Core::ICore::settings());
s.toSettings();
for (ITestFramework *framework : TestFrameworkManager::registeredFrameworks()) {
framework->setActive(s.frameworks.value(framework->id(), false));