feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Make aspect settings access implicit

Browse Source 
Generally, aspects should use fromMap/toMap, but some older pages
use {from,to}Settings with always the same ICore::settings().

To make that less intrusive on the user code side, make that globally
implicit.

Task-number: QTCREATORBUG-29167
Change-Id: I29a8e23a31eb8061bb143e93931a07c6741eb7f9
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2023-07-06 09:57:16 +02:00
parent 9f1b56e91a
commit 91513a53dd
37 changed files with 111 additions and 123 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/debugger/console/console.cpp
View File

@@ -202,10 +202,9 @@ bool Console::canNavigate() const
void Console::readSettings()
{
QSettings *settings = Core::ICore::settings();
m_showDebug.readSettings(settings);
m_showWarning.readSettings(settings);
m_showError.readSettings(settings);
m_showDebug.readSettings();
m_showWarning.readSettings();
m_showError.readSettings();
}
void Console::setContext(const QString &context)
@@ -215,10 +214,9 @@ void Console::setContext(const QString &context)
void Console::writeSettings() const
{
QSettings *settings = Core::ICore::settings();
m_showDebug.writeSettings(settings);
m_showWarning.writeSettings(settings);
m_showError.writeSettings(settings);
m_showDebug.writeSettings();
m_showWarning.writeSettings();
m_showError.writeSettings();
}
void Console::setScriptEvaluator(const ScriptEvaluator &evaluator)