From 919b97b75060770fb6f457527e2118041f0d5b7d Mon Sep 17 00:00:00 2001 From: Christian Stenger Date: Mon, 20 Feb 2023 15:45:46 +0100 Subject: [PATCH] AutoTest: Remove gtest notes from visual tree GTest uses a linear output format while we use a tree to group the results. Some information which make sense for the linear result cannot be placed correctly into the visual tree at all without breaking either the tree layout or displaying the result at unexpected locations inside the tree. So, omitting these information to avoid confusion seems to be the best trade-off as the information is still present inside the text output if needed. Change-Id: Ifd72bbf7e88993b4c76765597288e1531b50ee9a Reviewed-by: Reviewed-by: David Schulz --- src/plugins/autotest/gtest/gtestoutputreader.cpp | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/plugins/autotest/gtest/gtestoutputreader.cpp b/src/plugins/autotest/gtest/gtestoutputreader.cpp index 2c2aee07a6e..a24377bef7a 100644 --- a/src/plugins/autotest/gtest/gtestoutputreader.cpp +++ b/src/plugins/autotest/gtest/gtestoutputreader.cpp @@ -69,13 +69,8 @@ void GTestOutputReader::processOutputLine(const QByteArray &outputLine) m_iteration = match.captured(1).toInt(); m_description.clear(); } else if (line.startsWith(QStringLiteral("Note:"))) { - m_description = line; - if (m_iteration > 1) - m_description.append(' ' + Tr::tr("(iteration %1)").arg(m_iteration)); - GTestResult testResult(id(), {}, m_projectFile); - testResult.setResult(ResultType::MessageInternal); - testResult.setDescription(m_description); - reportResult(testResult); + // notes contain insignificant information we fail to include properly into the + // visual tree, so ignore them here as they are available inside the text display anyhow m_description.clear(); } else if (ExactMatch match = disabledTests.match(line)) { m_disabled = match.captured(1).toInt();