feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Lua: Fix off-by-ones in Layouting

Browse Source 
Change-Id: I4b29ff453ab29a26ec2300f70c0d1232f30575f1
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This commit is contained in:
hjk
2024-05-28 16:40:02 +02:00
parent 4bf55f3239
commit 91d0ca304a
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/lua/bindings/layout.cpp
View File

@@ -60,7 +60,7 @@ void constructWidget(std::unique_ptr<T> &widget, const sol::table &children)
widget->setWindowTitle(children.get_or<QString>("windowTitle", ""));
widget->setToolTip(children.get_or<QString>("toolTip", ""));
for (size_t i = 1; i < children.size(); ++i) {
for (size_t i = 1; i <= children.size(); ++i) {
const auto &child = children[i];
if (child.is<Layout>())
widget->setLayout(*child.get<Layout *>());
@@ -147,7 +147,7 @@ std::unique_ptr<TabWidget> constructTabWidget(const sol::table &children, QObjec
{
std::unique_ptr<TabWidget> item(new TabWidget({}));
setProperties(item, children, guard);
for (size_t i = 1; i < children.size(); ++i) {
for (size_t i = 1; i <= children.size(); ++i) {
const auto &child = children[i];
if (child.is<Tab *>())
addToTabWidget(item.get(), *child.get<Tab *>());
@@ -160,7 +160,7 @@ std::unique_ptr<Splitter> constructSplitter(const sol::table &children)
std::unique_ptr<Splitter> item(new Splitter({}));
constructWidget(item, children);
for (size_t i = 1; i < children.size(); ++i) {
for (size_t i = 1; i <= children.size(); ++i) {
const auto &child = children[i];
if (child.is<Layout *>()) {
addToSplitter(item.get(), *child.get<Layout *>());