From 91ffe63e1a0abe23a2207734cce14c65b7aca30c Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Tue, 15 Dec 2015 17:32:24 +0100 Subject: [PATCH] TextBrowserHelpViewer: Fix opening external links External links were not opening at all. The logic for that was present for TextBrowserHelpViewer::setSource, but clicking on links would directly go through the text browsers loadResource method. Avoid that by turning off openLinks and handling the anchorClicked signal instead. Task-number: QTCREATORBUG-15491 Change-Id: I86017f14138b98738221c1aed42c37551feaf671 Reviewed-by: Kai Koehne --- src/plugins/help/textbrowserhelpviewer.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/plugins/help/textbrowserhelpviewer.cpp b/src/plugins/help/textbrowserhelpviewer.cpp index 710f00f870d..747816dc8b6 100644 --- a/src/plugins/help/textbrowserhelpviewer.cpp +++ b/src/plugins/help/textbrowserhelpviewer.cpp @@ -55,6 +55,7 @@ TextBrowserHelpViewer::TextBrowserHelpViewer(QWidget *parent) : HelpViewer(parent) , m_textBrowser(new TextBrowserHelpWidget(this)) { + m_textBrowser->setOpenLinks(false); QVBoxLayout *layout = new QVBoxLayout; setLayout(layout); layout->setContentsMargins(0, 0, 0, 0); @@ -68,6 +69,8 @@ TextBrowserHelpViewer::TextBrowserHelpViewer(QWidget *parent) p.setColor(QPalette::Text, Qt::black); setPalette(p); + connect(m_textBrowser, &TextBrowserHelpWidget::anchorClicked, + this, &TextBrowserHelpViewer::setSource); connect(m_textBrowser, SIGNAL(sourceChanged(QUrl)), this, SIGNAL(titleChanged())); connect(m_textBrowser, SIGNAL(forwardAvailable(bool)), this, SIGNAL(forwardAvailable(bool))); connect(m_textBrowser, SIGNAL(backwardAvailable(bool)), this, SIGNAL(backwardAvailable(bool)));