From 9277c58e428fd570a1a2328765815eb2a31eca27 Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Thu, 17 Dec 2020 10:25:00 +0100 Subject: [PATCH] Do not pop up general messages pane General messages pane should only be opened on direct user interaction. Task-number: QTCREATORBUG-24430 Change-Id: Ib4c72b1bb07c27aabc74eb62c56061d5548b677d Reviewed-by: David Schulz --- src/plugins/beautifier/beautifierplugin.cpp | 2 +- src/plugins/clangtools/executableinfo.cpp | 4 ++-- src/plugins/imageviewer/imageview.cpp | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/plugins/beautifier/beautifierplugin.cpp b/src/plugins/beautifier/beautifierplugin.cpp index f1f15da32c2..f67495396c2 100644 --- a/src/plugins/beautifier/beautifierplugin.cpp +++ b/src/plugins/beautifier/beautifierplugin.cpp @@ -191,7 +191,7 @@ void BeautifierPluginPrivate::autoFormatOnSave(Core::IDocument *document) void BeautifierPlugin::showError(const QString &error) { - Core::MessageManager::write(tr("Error in Beautifier: %1").arg(error.trimmed())); + Core::MessageManager::writeFlashing(tr("Error in Beautifier: %1").arg(error.trimmed())); } QString BeautifierPlugin::msgCannotGetConfigurationFile(const QString &command) diff --git a/src/plugins/clangtools/executableinfo.cpp b/src/plugins/clangtools/executableinfo.cpp index d8ab050c20c..bd5a2b08809 100644 --- a/src/plugins/clangtools/executableinfo.cpp +++ b/src/plugins/clangtools/executableinfo.cpp @@ -59,8 +59,8 @@ static QString runExecutable(const Utils::CommandLine &commandLine, if (response.result != SynchronousProcessResponse::Finished && (failSilently == FailSilently::No || response.result != SynchronousProcessResponse::FinishedError)) { - Core::MessageManager::write(response.exitMessage(commandLine.toUserOutput(), 10)); - Core::MessageManager::write(QString::fromUtf8(response.allRawOutput())); + Core::MessageManager::writeFlashing(response.exitMessage(commandLine.toUserOutput(), 10)); + Core::MessageManager::writeFlashing(QString::fromUtf8(response.allRawOutput())); return {}; } diff --git a/src/plugins/imageviewer/imageview.cpp b/src/plugins/imageviewer/imageview.cpp index 269c5501629..cb86d38c8ac 100644 --- a/src/plugins/imageviewer/imageview.cpp +++ b/src/plugins/imageviewer/imageview.cpp @@ -155,7 +155,7 @@ bool ImageView::exportSvg(const ExportData &ed) .arg(QDir::toNativeSeparators(ed.fileName)) .arg(ed.size.width()).arg(ed.size.height()) .arg(QFileInfo(ed.fileName).size()); - Core::MessageManager::write(message); + Core::MessageManager::writeDisrupting(message); } else { const QString message = tr("Could not write file \"%1\".").arg(QDir::toNativeSeparators(ed.fileName)); QMessageBox::critical(this, tr("Export Image"), message);