feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Core: Fix item flag on locator settingspage

Browse Source 
Do not make the 'included by default' column editable as this would make
the column act strange on double clicks.
Instead of providing a non-functional change opportunity for the
checkstate's value this is now handled similar to the double click on
other columns.

Change-Id: Id2851b2bfe2b7cda8c3231f58bf436196a533171
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Christian Stenger
2023-04-27 08:03:48 +02:00
parent 3aec6b776c
commit 927c34df2f
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/coreplugin/locator/locatorsettingspage.cpp
View File

@@ -85,7 +85,7 @@ QVariant FilterItem::data(int column, int role) const
return m_filter->shortcutString(); return m_filter->shortcutString();
break; break;
case FilterIncludedByDefault: case FilterIncludedByDefault:
if (role == Qt::CheckStateRole || role == SortRole || role == Qt::EditRole) if (role == Qt::CheckStateRole || role == SortRole)
return m_filter->isIncludedByDefault() ? Qt::Checked : Qt::Unchecked; return m_filter->isIncludedByDefault() ? Qt::Checked : Qt::Unchecked;
break; break;
default: default:
@@ -102,7 +102,7 @@ Qt::ItemFlags FilterItem::flags(int column) const
if (column == FilterPrefix) if (column == FilterPrefix)
return Qt::ItemIsSelectable | Qt::ItemIsEnabled | Qt::ItemIsEditable; return Qt::ItemIsSelectable | Qt::ItemIsEnabled | Qt::ItemIsEditable;
if (column == FilterIncludedByDefault) if (column == FilterIncludedByDefault)
return Qt::ItemIsSelectable | Qt::ItemIsEnabled | Qt::ItemIsEditable | Qt::ItemIsUserCheckable; return Qt::ItemIsSelectable | Qt::ItemIsEnabled | Qt::ItemIsUserCheckable;
return Qt::ItemIsSelectable | Qt::ItemIsEnabled; return Qt::ItemIsSelectable | Qt::ItemIsEnabled;
} }