From 928dd20101f7a6ee4d40b320b25a60a52fbba228 Mon Sep 17 00:00:00 2001 From: hjk Date: Fri, 2 Mar 2018 10:08:54 +0100 Subject: [PATCH] TextEditor: Do not put settings pages into global object pool No need for it. Change-Id: I401f8c2894c74f331311f0025df29972142739c9 Reviewed-by: David Schulz --- src/plugins/texteditor/texteditorsettings.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/plugins/texteditor/texteditorsettings.cpp b/src/plugins/texteditor/texteditorsettings.cpp index 9e4b9dc46dd..2338f01c2d2 100644 --- a/src/plugins/texteditor/texteditorsettings.cpp +++ b/src/plugins/texteditor/texteditorsettings.cpp @@ -335,7 +335,6 @@ TextEditorSettings::TextEditorSettings() d->m_fontSettingsPage = new FontSettingsPage(formatDescr, Constants::TEXT_EDITOR_FONT_SETTINGS, this); - ExtensionSystem::PluginManager::addObject(d->m_fontSettingsPage); // Add the GUI used to configure the tab, storage and interaction settings BehaviorSettingsPageParameters behaviorSettingsPageParameters; @@ -343,25 +342,18 @@ TextEditorSettings::TextEditorSettings() behaviorSettingsPageParameters.displayName = tr("Behavior"); behaviorSettingsPageParameters.settingsPrefix = QLatin1String("text"); d->m_behaviorSettingsPage = new BehaviorSettingsPage(behaviorSettingsPageParameters, this); - ExtensionSystem::PluginManager::addObject(d->m_behaviorSettingsPage); DisplaySettingsPageParameters displaySettingsPageParameters; displaySettingsPageParameters.id = Constants::TEXT_EDITOR_DISPLAY_SETTINGS; displaySettingsPageParameters.displayName = tr("Display"); displaySettingsPageParameters.settingsPrefix = QLatin1String("text"); d->m_displaySettingsPage = new DisplaySettingsPage(displaySettingsPageParameters, this); - ExtensionSystem::PluginManager::addObject(d->m_displaySettingsPage); d->m_highlighterSettingsPage = new HighlighterSettingsPage(Constants::TEXT_EDITOR_HIGHLIGHTER_SETTINGS, this); - ExtensionSystem::PluginManager::addObject(d->m_highlighterSettingsPage); - d->m_snippetsSettingsPage = new SnippetsSettingsPage(Constants::TEXT_EDITOR_SNIPPETS_SETTINGS, this); - ExtensionSystem::PluginManager::addObject(d->m_snippetsSettingsPage); - d->m_completionSettingsPage = new CompletionSettingsPage(this); - ExtensionSystem::PluginManager::addObject(d->m_completionSettingsPage); connect(d->m_fontSettingsPage, &FontSettingsPage::changed, this, &TextEditorSettings::fontSettingsChanged);