forked from qt-creator/qt-creator
Debugger: Merge debug mode and analyze mode
On the user-visible side, only the 'Analyze' mode button disappears, and instead a combobox to switch between different tools in appears in the Debug mode toolbar. Internally, that's quite some re-organzition: The centralized 'Analyze mode is busy' flag is gone, allowing us to run e.g. ClangStaticAnalyzer and MemCheck in parallel. Analyzer tools and debugger now share the same mechanism to generate/load/save dock widgets. Analyzer tools now create and handle their own start/stop button when appropriate. In general, Analyzer tools can create/handle more than one run control at a time. Further consolidation is possible, e.g. RunControl state handling could be merged into the base ProjectExplorer::RunControl to avoid the still existing duplication in ~15 instances. Change-Id: I91e5940ebc4211f98056d507cf2f7b5f8efe7f07 Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
This commit is contained in:
@@ -38,7 +38,7 @@
|
||||
namespace Valgrind {
|
||||
namespace Internal {
|
||||
|
||||
class ValgrindRunControl : public Analyzer::AnalyzerRunControl
|
||||
class ValgrindRunControl : public Debugger::AnalyzerRunControl
|
||||
{
|
||||
Q_OBJECT
|
||||
|
||||
@@ -46,8 +46,9 @@ public:
|
||||
ValgrindRunControl(ProjectExplorer::RunConfiguration *runConfiguration,
|
||||
Core::Id runMode);
|
||||
|
||||
bool startEngine() override;
|
||||
void stopEngine() override;
|
||||
void start() override;
|
||||
StopResult stop() override;
|
||||
bool isRunning() const override;
|
||||
|
||||
QString executable() const;
|
||||
|
||||
@@ -70,6 +71,7 @@ private:
|
||||
QStringList genericToolArguments() const;
|
||||
|
||||
private:
|
||||
bool m_isRunning = false;
|
||||
bool m_isStopping = false;
|
||||
};
|
||||
|
||||
|
||||
Reference in New Issue
Block a user