feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangCodeModel: Another clangd cursor adjustment

Browse Source 
This time for the case where we are after the last character of a
function call argument.

Fixes: QTCREATORBUG-26638
Change-Id: I634fa91e87103a7ae82e3a43246dfbc7069dbbdc
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
This commit is contained in:
Christian Kandeler
2021-12-07 11:40:13 +01:00
parent ca9742e2a1
commit 92e3eb722a
1 changed files with 51 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
src/plugins/clangcodemodel/clangdclient.cpp
View File

@@ -2385,11 +2385,21 @@ QTextCursor ClangdClient::Private::adjustedCursor(const QTextCursor &cursor,
if (!cppDoc) if (!cppDoc)
return cursor; return cursor;
const QList<AST *> builtinAstPath = ASTPath(cppDoc)(cursor); const QList<AST *> builtinAstPath = ASTPath(cppDoc)(cursor);
for (auto it = builtinAstPath.rbegin(); it != builtinAstPath.rend(); ++it) {
const MemberAccessAST * const memberAccess = (*it)->asMemberAccess();
if (!memberAccess)
continue;
const TranslationUnit * const tu = cppDoc->translationUnit(); const TranslationUnit * const tu = cppDoc->translationUnit();
const auto posForToken = [doc, tu](int tok) {
int line, column;
tu->getTokenPosition(tok, &line, &column);
return Utils::Text::positionInText(doc->document(), line, column);
};
const auto leftMovedCursor = [cursor] {
QTextCursor c = cursor;
c.setPosition(cursor.position() - 1);
return c;
};
for (auto it = builtinAstPath.rbegin(); it != builtinAstPath.rend(); ++it) {
// s|.x or s|->x
if (const MemberAccessAST * const memberAccess = (*it)->asMemberAccess()) {
switch (tu->tokenAt(memberAccess->access_token).kind()) { switch (tu->tokenAt(memberAccess->access_token).kind()) {
case T_DOT: case T_DOT:
break; break;
@@ -2407,14 +2417,28 @@ QTextCursor ClangdClient::Private::adjustedCursor(const QTextCursor &cursor,
default: default:
return cursor; return cursor;
} }
int dotLine, dotColumn; if (posForToken(memberAccess->access_token) != cursor.position())
tu->getTokenPosition(memberAccess->access_token, &dotLine, &dotColumn);
const int dotPos = Utils::Text::positionInText(doc->document(), dotLine, dotColumn);
if (dotPos != cursor.position())
return cursor; return cursor;
QTextCursor c = cursor; return leftMovedCursor();
c.setPosition(cursor.position() - 1); }
return c;
// f(arg1|, arg2)
if (const CallAST *const callAst = (*it)->asCall()) {
const int tok = builtinAstPath.last()->lastToken();
if (posForToken(tok) != cursor.position())
return cursor;
if (tok == callAst->rparen_token)
return leftMovedCursor();
if (tu->tokenKind(tok) != T_COMMA)
return cursor;
// Guard against edge case of overloaded comma operator.
for (auto list = callAst->expression_list; list; list = list->next) {
if (list->value->lastToken() == tok)
return leftMovedCursor();
}
return cursor;
}
} }
return cursor; return cursor;
} }