feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: remove label from ArgumentsAspect

Browse Source 
BaseAspect already contain that information

Change-Id: I55fea913c2eec536b8946dc69a1d62e4d8ced7ac
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This commit is contained in:
David Schulz
2024-10-04 06:12:04 +02:00
parent 1d06ed5d90
commit 92e6b7061b
2 changed files with 2 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/plugins/projectexplorer/runconfigurationaspects.cpp
View File

@@ -314,12 +314,11 @@ ArgumentsAspect::ArgumentsAspect(AspectContainer *container)
: BaseAspect(container) : BaseAspect(container)
{ {
setDisplayName(Tr::tr("Arguments")); setDisplayName(Tr::tr("Arguments"));
setLabelText(Tr::tr("Command line arguments:"));
setId("ArgumentsAspect"); setId("ArgumentsAspect");
setSettingsKey("RunConfiguration.Arguments"); setSettingsKey("RunConfiguration.Arguments");
addDataExtractor(this, &ArgumentsAspect::arguments, &Data::arguments); addDataExtractor(this, &ArgumentsAspect::arguments, &Data::arguments);
m_labelText = Tr::tr("Command line arguments:");
} }
void ArgumentsAspect::setMacroExpander(const MacroExpander *expander) void ArgumentsAspect::setMacroExpander(const MacroExpander *expander)
@@ -369,14 +368,6 @@ void ArgumentsAspect::setArguments(const QString &arguments)
m_multiLineChooser->setPlainText(arguments); m_multiLineChooser->setPlainText(arguments);
} }
/*!
Sets the displayed label text to \a labelText.
*/
void ArgumentsAspect::setLabelText(const QString &labelText)
{
m_labelText = labelText;
}
/*! /*!
Adds a button to reset the main value of this aspect to the value Adds a button to reset the main value of this aspect to the value
computed by \a resetter. computed by \a resetter.
@@ -502,7 +493,7 @@ void ArgumentsAspect::addToLayoutImpl(Layout &builder)
containerLayout->setAlignment(m_resetButton, Qt::AlignTop); containerLayout->setAlignment(m_resetButton, Qt::AlignTop);
} }
builder.addItems({m_labelText, container}); addLabeledItem(builder, container);
} }
/*! /*!

2
src/plugins/projectexplorer/runconfigurationaspects.h
View File

@@ -100,7 +100,6 @@ public:
QString unexpandedArguments() const; QString unexpandedArguments() const;
void setArguments(const QString &arguments); void setArguments(const QString &arguments);
void setLabelText(const QString &labelText);
void setResetter(const std::function<QString()> &resetter); void setResetter(const std::function<QString()> &resetter);
void resetArguments(); void resetArguments();
void setMacroExpander(const Utils::MacroExpander *macroExpander); void setMacroExpander(const Utils::MacroExpander *macroExpander);
@@ -117,7 +116,6 @@ private:
QWidget *setupChooser(); QWidget *setupChooser();
QString m_arguments; QString m_arguments;
QString m_labelText;
QPointer<Utils::FancyLineEdit> m_chooser; QPointer<Utils::FancyLineEdit> m_chooser;
QPointer<QPlainTextEdit> m_multiLineChooser; QPointer<QPlainTextEdit> m_multiLineChooser;
QPointer<Utils::ExpandButton> m_multiLineButton; QPointer<Utils::ExpandButton> m_multiLineButton;