From 92fca248429808db83e84162db51cf96e1eddefe Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Thu, 14 Mar 2024 16:01:03 +0100 Subject: [PATCH] SystemSettingsWidget: Don't leak label and combobox on non mac host Change-Id: I9968a38055a8c1224aa09aad34ef5b3a30bd3490 Reviewed-by: Eike Ziller --- src/plugins/coreplugin/systemsettings.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/plugins/coreplugin/systemsettings.cpp b/src/plugins/coreplugin/systemsettings.cpp index 4ef1b0687b0..9a0a40d02e3 100644 --- a/src/plugins/coreplugin/systemsettings.cpp +++ b/src/plugins/coreplugin/systemsettings.cpp @@ -161,7 +161,7 @@ class SystemSettingsWidget : public IOptionsPageWidget { public: SystemSettingsWidget() - : m_fileSystemCaseSensitivityChooser(new QComboBox) + : m_fileSystemCaseSensitivityChooser(HostOsInfo::isMacHost() ? new QComboBox : nullptr) , m_externalFileBrowserEdit(new QLineEdit) , m_terminalComboBox(new QComboBox) , m_terminalOpenArgs(new QLineEdit) @@ -188,9 +188,6 @@ public: m_terminalOpenArgs->setToolTip( Tr::tr("Command line arguments used for \"%1\".").arg(FileUtils::msgTerminalHereAction())); - auto fileSystemCaseSensitivityLabel = new QLabel(Tr::tr("File system case sensitivity:")); - fileSystemCaseSensitivityLabel->setToolTip( - Tr::tr("Influences how file names are matched to decide if they are the same.")); auto resetFileBrowserButton = new QPushButton(Tr::tr("Reset")); resetFileBrowserButton->setToolTip(Tr::tr("Reset to default.")); auto helpExternalFileBrowserButton = new QToolButton; @@ -223,6 +220,9 @@ public: } grid.addRow({Span(4, s.patchCommand)}); if (HostOsInfo::isMacHost()) { + auto fileSystemCaseSensitivityLabel = new QLabel(Tr::tr("File system case sensitivity:")); + fileSystemCaseSensitivityLabel->setToolTip( + Tr::tr("Influences how file names are matched to decide if they are the same.")); grid.addRow({fileSystemCaseSensitivityLabel, m_fileSystemCaseSensitivityChooser}); }