feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TaskHandler: Use named property to store handler in action

Browse Source 
Change-Id: Ia946bcca0a1143b00d8a4ab2a71b2bd0f894aad8
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This commit is contained in:
hjk
2013-02-06 11:41:15 +01:00
committed by Tobias Hunger
parent 281eb3d414
commit 930a2e160c
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/projectexplorer/taskwindow.cpp
View File

@@ -310,7 +310,10 @@ TaskWindow::~TaskWindow()
static ITaskHandler *handler(QAction *action) static ITaskHandler *handler(QAction *action)
{ {
return qobject_cast<ITaskHandler *>(action->data().value<QObject *>()); QVariant prop = action->property("ITaskHandler");
ITaskHandler *handler = qobject_cast<ITaskHandler *>(prop.value<QObject *>());
QTC_CHECK(handler);
return handler;
} }
void TaskWindow::delayedInitialization() void TaskWindow::delayedInitialization()
@@ -328,7 +331,7 @@ void TaskWindow::delayedInitialization()
QAction *action = h->createAction(this); QAction *action = h->createAction(this);
QTC_ASSERT(action, continue); QTC_ASSERT(action, continue);
action->setData(qVariantFromValue(qobject_cast<QObject*>(h))); action->setProperty("ITaskHandler", qVariantFromValue(qobject_cast<QObject*>(h)));
connect(action, SIGNAL(triggered()), this, SLOT(actionTriggered())); connect(action, SIGNAL(triggered()), this, SLOT(actionTriggered()));
d->m_actions << action; d->m_actions << action;