feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

mime type matching optimization

Browse Source 
given that checking for a match is expensive and determining the
priority is cheap, it makes sense to match only if the priority is known
to be high enough.

Reviewed-by: Leandro Melo
This commit is contained in:
Oswald Buddenhagen
2011-03-09 11:40:10 +01:00
parent f3d6cd9cd1
commit 93195356a9
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/coreplugin/mimedatabase.cpp
View File

@@ -724,11 +724,9 @@ unsigned MimeType::matchesData(const QByteArray &data) const
unsigned priority = 0;
if (!data.isEmpty()) {
foreach (const IMagicMatcher::IMagicMatcherSharedPointer &matcher, m_d->magicMatchers) {
if (matcher->matches(data)) {
const unsigned magicPriority = matcher->priority();
if (magicPriority > priority)
priority = magicPriority;
}
const unsigned magicPriority = matcher->priority();
if (magicPriority > priority && matcher->matches(data))
priority = magicPriority;
}
}
return priority;