From 9320fb611a33bff132314e9e76679602f3d147ef Mon Sep 17 00:00:00 2001 From: Artem Sokolovskii Date: Wed, 4 Jan 2023 15:58:31 +0100 Subject: [PATCH] tracing: Remove foreach Change-Id: I74f17198a9f98f958924214ad2058e295b313373 Reviewed-by: Jarek Kobus --- src/libs/tracing/timelinemodelaggregator.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libs/tracing/timelinemodelaggregator.cpp b/src/libs/tracing/timelinemodelaggregator.cpp index 962051001f0..950bddda77e 100644 --- a/src/libs/tracing/timelinemodelaggregator.cpp +++ b/src/libs/tracing/timelinemodelaggregator.cpp @@ -60,7 +60,7 @@ void TimelineModelAggregator::setModels(const QVariantList &models) { Q_D(TimelineModelAggregator); - QList timelineModels = Utils::transform(models, [](const QVariant &model) { + const QList timelineModels = Utils::transform(models, [](const QVariant &model) { return qvariant_cast(model); }); @@ -68,14 +68,14 @@ void TimelineModelAggregator::setModels(const QVariantList &models) return; int prevHeight = height(); - foreach (TimelineModel *m, d->modelList) { + for (TimelineModel *m : std::as_const(d->modelList)) { disconnect(m, &TimelineModel::heightChanged, this, &TimelineModelAggregator::heightChanged); if (d->notesModel) d->notesModel->removeTimelineModel(m); } d->modelList = timelineModels; - foreach (TimelineModel *m, timelineModels) { + for (TimelineModel *m : timelineModels) { connect(m, &TimelineModel::heightChanged, this, &TimelineModelAggregator::heightChanged); if (d->notesModel) d->notesModel->addTimelineModel(m); @@ -95,7 +95,7 @@ QVariantList TimelineModelAggregator::models() const { Q_D(const TimelineModelAggregator); QVariantList ret; - foreach (TimelineModel *model, d->modelList) + for (TimelineModel *model : d->modelList) ret << QVariant::fromValue(model); return ret; }