forked from qt-creator/qt-creator
Always pass Core::Id by value.
Currently we pass in some places by value, elsewhere by const ref and for some weird reason also by const value in a lot of places. The latter is particularly annoying, as it is also used in interfaces and therefore forces all implementors to do the same, since leaving the "const" off is causing compiler warnings with MSVC. Change-Id: I65b87dc3cce0986b8a55ff6119cb752361027803 Reviewed-by: hjk <hjk121@nokiamail.com>
This commit is contained in:
@@ -763,7 +763,7 @@ void ProgressManager::setApplicationLabel(const QString &text)
|
||||
m_instance->doSetApplicationLabel(text);
|
||||
}
|
||||
|
||||
void ProgressManager::cancelTasks(const Id type)
|
||||
void ProgressManager::cancelTasks(Id type)
|
||||
{
|
||||
if (m_instance)
|
||||
m_instance->doCancelTasks(type);
|
||||
|
||||
@@ -60,7 +60,7 @@ public:
|
||||
static void setApplicationLabel(const QString &text);
|
||||
|
||||
public slots:
|
||||
static void cancelTasks(const Core::Id type);
|
||||
static void cancelTasks(Id type);
|
||||
|
||||
signals:
|
||||
void taskStarted(Core::Id type);
|
||||
|
||||
Reference in New Issue
Block a user