feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Always pass Core::Id by value.

Browse Source 
Currently we pass in some places by value, elsewhere by const ref and
for some weird reason also by const value in a lot of places. The latter
is particularly annoying, as it is also used in interfaces and therefore
forces all implementors to do the same, since leaving the "const" off is
causing compiler warnings with MSVC.

Change-Id: I65b87dc3cce0986b8a55ff6119cb752361027803
Reviewed-by: hjk <hjk121@nokiamail.com>
This commit is contained in:
Christian Kandeler
2014-07-01 11:08:26 +02:00
committed by hjk
parent 139449239c
commit 93304df038
208 changed files with 472 additions and 472 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/projectexplorer/taskwindow.h
View File

@@ -57,9 +57,9 @@ public:
void delayedInitialization();
int taskCount(const Core::Id &category = Core::Id()) const;
int warningTaskCount(const Core::Id &category = Core::Id()) const;
int errorTaskCount(const Core::Id &category = Core::Id()) const;
int taskCount(Core::Id category = Core::Id()) const;
int warningTaskCount(Core::Id category = Core::Id()) const;
int errorTaskCount(Core::Id category = Core::Id()) const;
// IOutputPane
QWidget *outputWidget(QWidget *);
@@ -85,15 +85,15 @@ signals:
void tasksCleared();
private slots:
void addCategory(const Core::Id &categoryId, const QString &displayName, bool visible);
void addCategory(Core::Id categoryId, const QString &displayName, bool visible);
void addTask(const ProjectExplorer::Task &task);
void removeTask(const ProjectExplorer::Task &task);
void updatedTaskFileName(unsigned int id, const QString &fileName);
void updatedTaskLineNumber(unsigned int id, int line);
void showTask(unsigned int id);
void openTask(unsigned int id);
void clearTasks(const Core::Id &categoryId);
void setCategoryVisibility(const Core::Id &categoryId, bool visible);
void clearTasks(Core::Id categoryId);
void setCategoryVisibility(Core::Id categoryId, bool visible);
void currentChanged(const QModelIndex &index);
void triggerDefaultHandler(const QModelIndex &index);