feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Do not use QAbstractItemModel::reset().

Browse Source 
Change-Id: Ie49bdf576a6d3543aef6df133b27c8827775c935
Rationale:
    a) It is conceptually cleaner to do the changes to the model
       in between calls to beginResetModel() and endResetModel,
       respectively.
    b) The function is deprecated in Qt 5, for exactly that reason.
Reviewed-by: hjk <qthjk@ovi.com>
This commit is contained in:
Christian Kandeler
2012-09-20 10:31:34 +02:00
committed by hjk
parent 1b3d637c1b
commit 938612c35e
26 changed files with 85 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/texteditor/snippets/snippetssettingspage.cpp
View File

@@ -165,8 +165,9 @@ QVariant SnippetsTableModel::headerData(int section, Qt::Orientation orientation
void SnippetsTableModel::load(const QString &groupId)
{
beginResetModel();
m_activeGroupId = groupId;
reset();
endResetModel();
}
QList<QString> SnippetsTableModel::groupIds() const
@@ -219,14 +220,16 @@ void SnippetsTableModel::revertBuitInSnippet(const QModelIndex &modelIndex)
void SnippetsTableModel::restoreRemovedBuiltInSnippets()
{
beginResetModel();
m_collection->restoreRemovedSnippets(m_activeGroupId);
reset();
endResetModel();
}
void SnippetsTableModel::resetSnippets()
{
beginResetModel();
m_collection->reset(m_activeGroupId);
reset();
endResetModel();
}
void SnippetsTableModel::replaceSnippet(const Snippet &snippet, const QModelIndex &modelIndex)