Core: Improve themeing of LineEdit icons (search, clear, ...)

...by providing a specific theme color role PanelTextColorMid.
Also, this fixes the opacity of editclear.png and magnifier.png

Change-Id: I0293eaa397a0b64595ddd66f608bdfe9f7b8e705
Reviewed-by: Alessandro Portale <alessandro.portale@theqtcompany.com>

share/qtcreator/themes/dark.creatortheme

@@ -83,6 +83,7 @@ PanelButtonToolBackgroundColorHover=hoverBackground
 PanelStatusBarBackgroundColor=shadowBackground
 PanelsWidgetSeparatorLineColor=0
 PanelTextColorDark=text
+PanelTextColorMid=ffa0a0a0
 PanelTextColorLight=text
 ProgressBarColorError=error
 ProgressBarColorFinished=ff5aaa3c

share/qtcreator/themes/default.creatortheme

@@ -78,6 +78,7 @@ PanelButtonToolBackgroundColorHover=25ffffff
 PanelStatusBarBackgroundColor=ffff0000
 PanelsWidgetSeparatorLineColor=ffbfbcb8
 PanelTextColorDark=darkText
+PanelTextColorMid=ff909090
 PanelTextColorLight=brightText
 ProgressBarColorError=d2ff3c00
 ProgressBarColorFinished=ff5aaa3c

src/libs/utils/theme/theme.h

@@ -112,6 +112,7 @@ public:
         PanelStatusBarBackgroundColor,
         PanelsWidgetSeparatorLineColor,
         PanelTextColorDark,
+        PanelTextColorMid,
         PanelTextColorLight,
         ProgressBarColorError,
         ProgressBarColorFinished,

src/libs/utils/utilsicons.h

@@ -37,7 +37,7 @@ namespace Utils {
 namespace Icons {
 
 const Utils::Icon EDIT_CLEAR({
-        {QLatin1String(":/core/images/editclear.png"), Utils::Theme::BackgroundColorHover}}, Utils::Icon::Style::Tinted);
+        {QLatin1String(":/core/images/editclear.png"), Utils::Theme::PanelTextColorMid}}, Utils::Icon::Style::Tinted);
 
 } // namespace Icons
 } // namespace Utils

src/plugins/coreplugin/coreicons.h

@@ -90,7 +90,7 @@ const Utils::Icon NEXT({
 const Utils::Icon PREV({
         {QLatin1String(":/core/images/prev.png"), Utils::Theme::IconsNavigationArrowsColor}});
 const Utils::Icon MAGNIFIER({
-        {QLatin1String(":/core/images/magnifier.png"), Utils::Theme::BackgroundColorHover}}, Utils::Icon::Style::Tinted);
+        {QLatin1String(":/core/images/magnifier.png"), Utils::Theme::PanelTextColorMid}}, Utils::Icon::Style::Tinted);
 const Utils::Icon CLEAN_PANE({
         {QLatin1String(":/core/images/clean_pane_small.png"), Utils::Theme::IconsBaseColor}});
 const Utils::Icon RELOAD({

src/tools/icons/qtcreatoricons.svg

@@ -3252,7 +3252,7 @@
        transform="translate(-139,-80)"
        style="">
       <rect
-         style="opacity:0.60100002;fill:#ffffff;fill-opacity:1;"
+         style="fill:#ffffff;fill-opacity:1"
          id="rect3817-2-9-1-9-6"
          width="16"
          height="16"
@@ -3291,7 +3291,7 @@
        id="src/plugins/coreplugin/images/magnifier"
        transform="translate(37,-80)">
       <rect
-         style="opacity:0.60100002;fill:#ffffff;fill-opacity:1"
+         style="fill:#ffffff;fill-opacity:1"
          id="rect3817-2-9-1-9-6-0"
          width="17"
          height="11"