feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlJSEditor: warn when editing .ui.qml, activate designer checks

Browse Source 
Change-Id: I2f6d39633341bd1197d16c5c097573d4ab090896
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@digia.com>
This commit is contained in:
Thomas Hartmann
2014-10-14 10:10:58 +02:00
parent e2456cf8cf
commit 93c3ee1bbf
5 changed files with 68 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
src/libs/qmljs/qmljscheck.cpp
View File

@@ -568,12 +568,13 @@ Check::Check(Document::Ptr doc, const ContextPtr &context)
disableMessage(HintBinaryOperatorSpacing);
disableMessage(HintOneStatementPerLine);
disableMessage(HintExtraParentheses);
disableMessage(WarnImperativeCodeNotEditableInVisualDesigner);
disableMessage(WarnUnsupportedTypeInVisualDesigner);
disableMessage(WarnReferenceToParentItemNotSupportedByVisualDesigner);
disableMessage(WarnUndefinedValueForVisualDesigner);
disableMessage(WarnStatesOnlyInRootItemForVisualDesigner);
disableMessage(ErrUnsupportedRootTypeInVisualDesigner);
if (isQtQuick2Ui()) {
enableQmlDesignerChecks();
} else {
disableQmlDesignerChecks();
disableQmlDesignerUiFileChecks();
}
}
Check::~Check()
@@ -601,6 +602,37 @@ void Check::disableMessage(Type type)
_enabledMessages.remove(type);
}
void Check::enableQmlDesignerChecks()
{
enableMessage(StaticAnalysis::WarnImperativeCodeNotEditableInVisualDesigner);
enableMessage(StaticAnalysis::WarnUnsupportedTypeInVisualDesigner);
enableMessage(StaticAnalysis::WarnReferenceToParentItemNotSupportedByVisualDesigner);
enableMessage(StaticAnalysis::WarnReferenceToParentItemNotSupportedByVisualDesigner);
enableMessage(StaticAnalysis::WarnAboutQtQuick1InsteadQtQuick2);
enableMessage(StaticAnalysis::ErrUnsupportedRootTypeInVisualDesigner);
//## triggers too often ## check.enableMessage(StaticAnalysis::WarnUndefinedValueForVisualDesigner);
}
void Check::disableQmlDesignerChecks()
{
disableMessage(WarnImperativeCodeNotEditableInVisualDesigner);
disableMessage(WarnUnsupportedTypeInVisualDesigner);
disableMessage(WarnReferenceToParentItemNotSupportedByVisualDesigner);
disableMessage(WarnUndefinedValueForVisualDesigner);
disableMessage(WarnStatesOnlyInRootItemForVisualDesigner);
disableMessage(ErrUnsupportedRootTypeInVisualDesigner);
}
void Check::enableQmlDesignerUiFileChecks()
{
}
void Check::disableQmlDesignerUiFileChecks()
{
}
bool Check::preVisit(Node *ast)
{
_chain.append(ast);