From 93d4b057cf5766c9ec0b5f6f13f907dfdbd6d63a Mon Sep 17 00:00:00 2001
From: Knud Dollereder <knud.dollereder@qt.io>
Date: Wed, 21 Sep 2022 13:22:34 +0200
Subject: [PATCH] Check for more dirty flags

This fixes an issue of the formeditor which did not update properly if
components contain items that have one of zvalue, opacity or visibility
attributes animated.

Change-Id: I1b20f09177878419b2b18aaf94c84b6ae437be7d
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
---
 .../qml2puppet/instances/qt5rendernodeinstanceserver.cpp  | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5rendernodeinstanceserver.cpp b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5rendernodeinstanceserver.cpp
index 59e7a4aa821..c83937b733a 100644
--- a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5rendernodeinstanceserver.cpp
+++ b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5rendernodeinstanceserver.cpp
@@ -100,7 +100,13 @@ void Qt5RenderNodeInstanceServer::collectItemChangesAndSendChangeCommands()
                                     m_dirtyInstanceSet.insert(instanceForObject(effectParent));
                                 }
                             }
-                        } else if (DesignerSupport::isDirty(item, DesignerSupport::AllMask)) {
+                        } else if (DesignerSupport::isDirty(
+                                item,
+                                DesignerSupport::DirtyType(
+                                    DesignerSupport::AllMask
+                                    | DesignerSupport::ZValue
+                                    | DesignerSupport::OpacityValue
+                                    | DesignerSupport::Visible))) {
                             ServerNodeInstance ancestorInstance = findNodeInstanceForItem(
                                 item->parentItem());
                             if (ancestorInstance.isValid())