feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangTools: Fix fall-through warning

Browse Source 
GCC does not realize that all cases lead to a return statement.

Change-Id: I0b6fc7b349b8dc09b739f3423121d2e760c74701
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
This commit is contained in:
Christian Kandeler
2019-02-12 13:11:15 +01:00
parent ffd2fee26a
commit 94425336fd
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/clangtools/clangtoolsdiagnosticmodel.cpp
View File

@@ -428,6 +428,7 @@ QVariant DiagnosticItem::data(int column, int role) const
case FixitStatus::NotScheduled: case FixitStatus::NotScheduled:
return true; return true;
} }
break;
case Qt::CheckStateRole: { case Qt::CheckStateRole: {
switch (m_fixitStatus) { switch (m_fixitStatus) {
case FixitStatus::NotAvailable: case FixitStatus::NotAvailable:
@@ -439,6 +440,7 @@ QVariant DiagnosticItem::data(int column, int role) const
case FixitStatus::Scheduled: case FixitStatus::Scheduled:
return Qt::Checked; return Qt::Checked;
} }
break;
} }
case Qt::DisplayRole: case Qt::DisplayRole:
return QString("%1: %2").arg(lineColumnString(m_diagnostic.location), return QString("%1: %2").arg(lineColumnString(m_diagnostic.location),