From 9452c36025efe8b3dbef132dc751b62ab4338de4 Mon Sep 17 00:00:00 2001 From: Tobias Hunger Date: Thu, 12 Jul 2018 12:10:12 +0200 Subject: [PATCH] ProjectExplorer: Simplify BuildConfiguration a bit Change-Id: Ia44049039c32a598b6da212290d339b8f3705835 Reviewed-by: Ulf Hermann --- src/plugins/projectexplorer/buildconfiguration.cpp | 7 +------ src/plugins/projectexplorer/buildconfiguration.h | 1 - 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/plugins/projectexplorer/buildconfiguration.cpp b/src/plugins/projectexplorer/buildconfiguration.cpp index 72b0e4c0760..ddd9ef43bee 100644 --- a/src/plugins/projectexplorer/buildconfiguration.cpp +++ b/src/plugins/projectexplorer/buildconfiguration.cpp @@ -76,7 +76,7 @@ BuildConfiguration::BuildConfiguration(Target *target, Core::Id id) updateCacheAndEmitEnvironmentChanged(); connect(target, &Target::kitChanged, - this, &BuildConfiguration::handleKitUpdate); + this, &BuildConfiguration::updateCacheAndEmitEnvironmentChanged); connect(this, &BuildConfiguration::environmentChanged, this, &BuildConfiguration::emitBuildDirectoryChanged); } @@ -183,11 +183,6 @@ void BuildConfiguration::updateCacheAndEmitEnvironmentChanged() emit environmentChanged(); // might trigger buildDirectoryChanged signal! } -void BuildConfiguration::handleKitUpdate() -{ - updateCacheAndEmitEnvironmentChanged(); -} - void BuildConfiguration::emitBuildDirectoryChanged() { if (buildDirectory() != m_lastEmmitedBuildDirectory) { diff --git a/src/plugins/projectexplorer/buildconfiguration.h b/src/plugins/projectexplorer/buildconfiguration.h index dd649e1f268..c8832811264 100644 --- a/src/plugins/projectexplorer/buildconfiguration.h +++ b/src/plugins/projectexplorer/buildconfiguration.h @@ -108,7 +108,6 @@ protected: void updateCacheAndEmitEnvironmentChanged(); private: - void handleKitUpdate(); void emitBuildDirectoryChanged(); bool m_clearSystemEnvironment = false;