forked from qt-creator/qt-creator
Valgrind: Keep tool names in the *ToolRunners only
Slightly less convoluted. Change-Id: I07410b49db05ea862fb82f3bffc25a5d7fb5a104 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
@@ -69,7 +69,6 @@ public:
|
||||
QHostAddress localServerAddress;
|
||||
QProcess::ProcessChannelMode channelMode = QProcess::SeparateChannels;
|
||||
bool m_finished = false;
|
||||
QString m_tool;
|
||||
|
||||
QTcpServer xmlServer;
|
||||
XmlProtocol::ThreadedParser parser;
|
||||
@@ -102,7 +101,6 @@ void ValgrindRunner::Private::run()
|
||||
this, &ValgrindRunner::Private::remoteProcessStarted);
|
||||
|
||||
QStringList fullArgs = m_valgrindArguments;
|
||||
fullArgs << QString("--tool=%1").arg(m_tool);
|
||||
if (HostOsInfo::isMacHost())
|
||||
// May be slower to start but without it we get no filenames for symbols.
|
||||
fullArgs << "--dsymutil=yes";
|
||||
@@ -212,7 +210,6 @@ void ValgrindRunner::Private::closed(bool success)
|
||||
ValgrindRunner::ValgrindRunner(QObject *parent)
|
||||
: QObject(parent), d(new Private(this))
|
||||
{
|
||||
setToolName("memcheck");
|
||||
}
|
||||
|
||||
ValgrindRunner::~ValgrindRunner()
|
||||
@@ -269,11 +266,6 @@ void ValgrindRunner::waitForFinished() const
|
||||
loop.exec();
|
||||
}
|
||||
|
||||
void ValgrindRunner::setToolName(const QString &toolName)
|
||||
{
|
||||
d->m_tool = toolName;
|
||||
}
|
||||
|
||||
static void handleSocketParameter(const QString &prefix, const QTcpServer &tcpServer,
|
||||
bool *useXml, QStringList *arguments)
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user