feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

debugger: make BreakpointData and BreakpointResult proper value types

Browse Source
This commit is contained in:
hjk
2010-11-15 14:12:05 +01:00
parent 8d59cff401
commit 956b54289e
6 changed files with 219 additions and 226 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/plugins/debugger/breakwindow.cpp
View File

@@ -363,14 +363,13 @@ void BreakWindow::contextMenuEvent(QContextMenuEvent *ev)
else if (act == addBreakpointAction)
addBreakpoint();
else if (act == breakAtThrowAction) {
// FIXME: Use the proper breakpoint type instead.
BreakpointData *data = new BreakpointData;
data->setFunctionName(BreakpointData::throwFunction);
BreakpointData data;
data.setFunctionName(BreakpointData::throwFunction);
handler->appendBreakpoint(data);
} else if (act == breakAtCatchAction) {
// FIXME: Use the proper breakpoint type instead.
BreakpointData *data = new BreakpointData;
data->setFunctionName(BreakpointData::catchFunction);
BreakpointData data;
data.setFunctionName(BreakpointData::catchFunction);
handler->appendBreakpoint(data);
}
}
@@ -396,25 +395,18 @@ void BreakWindow::deleteBreakpoints(const QModelIndexList &list)
handler->removeBreakpoint(handler->findBreakpointByIndex(index));
}
static bool editBreakpointInternal(BreakpointData *data, QWidget *parent)
void BreakWindow::editBreakpoint(BreakpointId id, QWidget *parent)
{
BreakpointDialog dialog(parent);
return dialog.showDialog(data);
}
bool BreakWindow::editBreakpoint(BreakpointId id, QWidget *parent)
{
BreakpointDialog dialog(parent);
return dialog.showDialog(breakHandler()->breakpointById(id));
dialog.showDialog(breakHandler()->breakpointById(id));
}
void BreakWindow::addBreakpoint()
{
BreakpointData *data = new BreakpointData();
if (editBreakpointInternal(data, this))
BreakpointData data;
BreakpointDialog dialog(this);
if (dialog.showDialog(&data))
breakHandler()->appendBreakpoint(data);
else
delete data;
}
void BreakWindow::editBreakpoints(const QModelIndexList &list)