forked from qt-creator/qt-creator
Wizards: changes the structure of Wizards
This patch introduces platforms as a top level topic when choosing a wizard. Also I changed the categories and priorities. Details: 1. I did change the way the dialog/view is structured in newdialog.cpp 2. I added platformName() and supportsPlatform() to BaseQtVersion. I needed two functions because the Simulator does not provide a platform and therefore has no platformName but supports two platforms. I still have to turn the platform names into proper constants. 3. I changed the categories and priorities to get the layout that was discussed. (I had to touch quite alot of files but this is mostly trivial) 4. I added a combobox that allows filtering for platforms. 5. I added flags() to IWizard to indicate that a wizard is platform independent. Change-Id: I86c7ad628a431ad06505c76580885c6e6c3ddc23 Reviewed-by: Alessandro Portale <alessandro.portale@nokia.com>
This commit is contained in:
committed by
Alessandro Portale
parent
ea23486847
commit
95a028e835
@@ -40,6 +40,7 @@
|
||||
#include <coreplugin/featureprovider.h>
|
||||
|
||||
#include <QtGui/QAbstractProxyModel>
|
||||
#include <QtGui/QSortFilterProxyModel>
|
||||
#include <QtGui/QItemSelectionModel>
|
||||
#include <QtGui/QHeaderView>
|
||||
#include <QtGui/QPushButton>
|
||||
@@ -55,6 +56,49 @@ namespace {
|
||||
|
||||
const int ICON_SIZE = 22;
|
||||
|
||||
struct WizardContainer
|
||||
{
|
||||
WizardContainer() : wizard(0), wizardOption(0) {}
|
||||
WizardContainer(Core::IWizard *w, int i): wizard(w), wizardOption(i) {}
|
||||
Core::IWizard *wizard;
|
||||
int wizardOption;
|
||||
};
|
||||
|
||||
inline Core::IWizard *wizardOfItem(const QStandardItem *item = 0)
|
||||
{
|
||||
if (!item)
|
||||
return 0;
|
||||
return item->data(Qt::UserRole).value<WizardContainer>().wizard;
|
||||
}
|
||||
|
||||
class PlatformFilterProxyModel : public QSortFilterProxyModel
|
||||
{
|
||||
// Q_OBJECT
|
||||
public:
|
||||
PlatformFilterProxyModel(QObject *parent = 0): QSortFilterProxyModel(parent) {}
|
||||
|
||||
void setPlatform(const QString& platform)
|
||||
{
|
||||
m_platform = platform;
|
||||
invalidateFilter();
|
||||
}
|
||||
|
||||
bool filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const
|
||||
{
|
||||
if (!sourceParent.isValid())
|
||||
return true;
|
||||
|
||||
QModelIndex sourceIndex = sourceModel()->index(sourceRow, 0, sourceParent);
|
||||
Core::IWizard *wizard = wizardOfItem(qobject_cast<QStandardItemModel*>(sourceModel())->itemFromIndex(sourceIndex));
|
||||
if (wizard)
|
||||
return wizard->isAvailable(m_platform);
|
||||
|
||||
return true;
|
||||
}
|
||||
private:
|
||||
QString m_platform;
|
||||
};
|
||||
|
||||
class TwoLevelProxyModel : public QAbstractProxyModel
|
||||
{
|
||||
// Q_OBJECT
|
||||
@@ -139,15 +183,9 @@ public:
|
||||
}
|
||||
};
|
||||
|
||||
|
||||
inline Core::IWizard *wizardOfItem(const QStandardItem *item = 0)
|
||||
{
|
||||
if (!item)
|
||||
return 0;
|
||||
return item->data(Qt::UserRole).value<Core::IWizard*>();
|
||||
}
|
||||
|
||||
}
|
||||
Q_DECLARE_METATYPE(WizardContainer)
|
||||
|
||||
using namespace Core;
|
||||
using namespace Core::Internal;
|
||||
@@ -166,9 +204,12 @@ NewDialog::NewDialog(QWidget *parent) :
|
||||
m_okButton->setText(tr("&Choose..."));
|
||||
|
||||
m_model = new QStandardItemModel(this);
|
||||
m_proxyModel = new TwoLevelProxyModel(this);
|
||||
m_proxyModel->setSourceModel(m_model);
|
||||
m_ui->templateCategoryView->setModel(m_proxyModel);
|
||||
m_twoLevelProxyModel = new TwoLevelProxyModel(this);
|
||||
m_twoLevelProxyModel->setSourceModel(m_model);
|
||||
m_filterProxyModel = new PlatformFilterProxyModel(this);
|
||||
m_filterProxyModel->setSourceModel(m_model);
|
||||
|
||||
m_ui->templateCategoryView->setModel(m_twoLevelProxyModel);
|
||||
m_ui->templateCategoryView->setEditTriggers(QAbstractItemView::NoEditTriggers);
|
||||
m_ui->templateCategoryView->setItemDelegate(new FancyTopLevelDelegate);
|
||||
|
||||
@@ -188,6 +229,8 @@ NewDialog::NewDialog(QWidget *parent) :
|
||||
|
||||
connect(m_okButton, SIGNAL(clicked()), this, SLOT(okButtonClicked()));
|
||||
connect(m_ui->buttonBox, SIGNAL(rejected()), this, SLOT(reject()));
|
||||
|
||||
connect(m_ui->comboBox, SIGNAL(currentIndexChanged(QString)), this, SLOT(setSelectedPlatform(QString)));
|
||||
}
|
||||
|
||||
// Sort by category. id
|
||||
@@ -204,32 +247,44 @@ void NewDialog::setWizards(QList<IWizard*> wizards)
|
||||
|
||||
qStableSort(wizards.begin(), wizards.end(), wizardLessThan);
|
||||
|
||||
|
||||
CategoryItemMap categories;
|
||||
CategoryItemMap platformMap;
|
||||
|
||||
m_model->clear();
|
||||
QStandardItem *parentItem = m_model->invisibleRootItem();
|
||||
|
||||
QStandardItem *projectKindItem = new QStandardItem(tr("Projects"));
|
||||
projectKindItem->setData(IWizard::ProjectWizard, Qt::UserRole);
|
||||
projectKindItem->setFlags(0); // disable item to prevent focus
|
||||
QStandardItem *filesClassesKindItem = new QStandardItem(tr("Files and Classes"));
|
||||
filesClassesKindItem->setData(IWizard::FileWizard, Qt::UserRole);
|
||||
filesClassesKindItem->setFlags(0); // disable item to prevent focus
|
||||
QStandardItem *parentItem = m_model->invisibleRootItem();
|
||||
|
||||
parentItem->appendRow(projectKindItem);
|
||||
parentItem->appendRow(filesClassesKindItem);
|
||||
|
||||
if (m_dummyIcon.isNull()) {
|
||||
m_dummyIcon = QPixmap(ICON_SIZE, ICON_SIZE);
|
||||
m_dummyIcon.fill(Qt::transparent);
|
||||
m_dummyIcon = QIcon(QLatin1String(Core::Constants::ICON_NEWFILE));
|
||||
}
|
||||
|
||||
QStringList availablePlatforms = IWizard::allAvailablePlatforms();
|
||||
|
||||
if (availablePlatforms.count() > 1) {
|
||||
m_ui->comboBox->addItem(tr("All templates"), QString());
|
||||
foreach (const QString &platform, availablePlatforms) {
|
||||
m_ui->comboBox->addItem(tr("%1 templates").arg(platform), platform);
|
||||
}
|
||||
} else {
|
||||
if (availablePlatforms.isEmpty()) {
|
||||
m_ui->comboBox->addItem(tr("All templates"), QString());
|
||||
} else {
|
||||
const QString platform = availablePlatforms.first();
|
||||
m_ui->comboBox->addItem(tr("%1 templates").arg(platform), platform);
|
||||
}
|
||||
m_ui->comboBox->setDisabled(true);
|
||||
}
|
||||
|
||||
foreach (IWizard *wizard, wizards) {
|
||||
// ensure category root
|
||||
const QString categoryName = wizard->category();
|
||||
|
||||
CategoryItemMap::iterator cit = categories.find(categoryName);
|
||||
if (cit == categories.end()) {
|
||||
QStandardItem *categoryItem = new QStandardItem();
|
||||
if (wizard->isAvailable(selectedPlatform())) {
|
||||
QStandardItem *kindItem;
|
||||
switch (wizard->kind()) {
|
||||
case IWizard::ProjectWizard:
|
||||
@@ -241,39 +296,8 @@ void NewDialog::setWizards(QList<IWizard*> wizards)
|
||||
kindItem = filesClassesKindItem;
|
||||
break;
|
||||
}
|
||||
kindItem->appendRow(categoryItem);
|
||||
m_categoryItems.append(categoryItem);
|
||||
categoryItem->setFlags(Qt::ItemIsEnabled | Qt::ItemIsSelectable);
|
||||
categoryItem->setText(wizard->displayCategory());
|
||||
categoryItem->setData(wizard->category(), Qt::UserRole);
|
||||
cit = categories.insert(categoryName, categoryItem);
|
||||
addItem(kindItem, wizard);
|
||||
}
|
||||
// add item
|
||||
if (wizard->isAvailable()) {
|
||||
QStandardItem *wizardItem = new QStandardItem(wizard->displayName());
|
||||
QIcon wizardIcon;
|
||||
|
||||
// spacing hack. Add proper icons instead
|
||||
if (wizard->icon().isNull()) {
|
||||
wizardIcon = m_dummyIcon;
|
||||
} else {
|
||||
wizardIcon = wizard->icon();
|
||||
}
|
||||
wizardItem->setIcon(wizardIcon);
|
||||
wizardItem->setData(QVariant::fromValue(wizard), Qt::UserRole);
|
||||
wizardItem->setFlags(Qt::ItemIsEnabled|Qt::ItemIsSelectable);
|
||||
cit.value()->appendRow(wizardItem);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
if (!projectKindItem->hasChildren()) {
|
||||
QModelIndex idx = projectKindItem->index();
|
||||
m_model->removeRow(idx.row());
|
||||
}
|
||||
if (!filesClassesKindItem->hasChildren()) {
|
||||
QModelIndex idx = filesClassesKindItem->index();
|
||||
m_model->removeRow(idx.row());
|
||||
}
|
||||
}
|
||||
|
||||
@@ -285,19 +309,19 @@ Core::IWizard *NewDialog::showDialog()
|
||||
if (!lastCategory.isEmpty())
|
||||
foreach(QStandardItem* item, m_categoryItems) {
|
||||
if (item->data(Qt::UserRole) == lastCategory) {
|
||||
idx = m_proxyModel->mapToSource(m_model->indexFromItem(item));
|
||||
idx = m_twoLevelProxyModel->mapToSource(m_model->indexFromItem(item));
|
||||
}
|
||||
}
|
||||
if (!idx.isValid())
|
||||
idx = m_proxyModel->index(0,0, m_proxyModel->index(0,0));
|
||||
idx = m_twoLevelProxyModel->index(0,0, m_twoLevelProxyModel->index(0,0));
|
||||
|
||||
m_ui->templateCategoryView->setCurrentIndex(idx);
|
||||
|
||||
// We need to set ensure that the category has default focus
|
||||
m_ui->templateCategoryView->setFocus(Qt::NoFocusReason);
|
||||
|
||||
for (int row = 0; row < m_proxyModel->rowCount(); ++row)
|
||||
m_ui->templateCategoryView->setExpanded(m_proxyModel->index(row, 0), true);
|
||||
for (int row = 0; row < m_twoLevelProxyModel->rowCount(); ++row)
|
||||
m_ui->templateCategoryView->setExpanded(m_twoLevelProxyModel->index(row, 0), true);
|
||||
|
||||
// Ensure that item description is visible on first show
|
||||
currentItemChanged(m_ui->templatesView->rootIndex().child(0,0));
|
||||
@@ -307,7 +331,7 @@ Core::IWizard *NewDialog::showDialog()
|
||||
const int retVal = exec();
|
||||
|
||||
idx = m_ui->templateCategoryView->currentIndex();
|
||||
lastCategory = m_model->itemFromIndex(m_proxyModel->mapToSource(idx))->data(Qt::UserRole).toString();
|
||||
lastCategory = m_model->itemFromIndex(m_twoLevelProxyModel->mapToSource(idx))->data(Qt::UserRole).toString();
|
||||
|
||||
if (retVal != Accepted)
|
||||
return 0;
|
||||
@@ -315,6 +339,19 @@ Core::IWizard *NewDialog::showDialog()
|
||||
return currentWizard();
|
||||
}
|
||||
|
||||
QString NewDialog::selectedPlatform() const
|
||||
{
|
||||
int index = m_ui->comboBox->currentIndex();
|
||||
|
||||
return m_ui->comboBox->itemData(index).toString();
|
||||
}
|
||||
|
||||
int NewDialog::selectedWizardOption() const
|
||||
{
|
||||
QStandardItem *item = m_model->itemFromIndex(m_ui->templatesView->currentIndex());
|
||||
return item->data(Qt::UserRole).value<WizardContainer>().wizardOption;
|
||||
}
|
||||
|
||||
NewDialog::~NewDialog()
|
||||
{
|
||||
delete m_ui;
|
||||
@@ -322,15 +359,50 @@ NewDialog::~NewDialog()
|
||||
|
||||
IWizard *NewDialog::currentWizard() const
|
||||
{
|
||||
return wizardOfItem(m_model->itemFromIndex(m_ui->templatesView->currentIndex()));
|
||||
QModelIndex index = m_filterProxyModel->mapToSource(m_ui->templatesView->currentIndex());
|
||||
return wizardOfItem(m_model->itemFromIndex(index));
|
||||
}
|
||||
|
||||
void NewDialog::addItem(QStandardItem *topLEvelCategoryItem, IWizard *wizard)
|
||||
{
|
||||
const QString categoryName = wizard->category();
|
||||
QStandardItem *categoryItem = 0;
|
||||
for (int i = 0; i < topLEvelCategoryItem->rowCount(); i++) {
|
||||
if (topLEvelCategoryItem->child(i, 0)->data(Qt::UserRole) == categoryName)
|
||||
categoryItem = topLEvelCategoryItem->child(i, 0);
|
||||
}
|
||||
if (!categoryItem) {
|
||||
categoryItem = new QStandardItem();
|
||||
topLEvelCategoryItem->appendRow(categoryItem);
|
||||
m_categoryItems.append(categoryItem);
|
||||
categoryItem->setFlags(Qt::ItemIsEnabled | Qt::ItemIsSelectable);
|
||||
categoryItem->setText(QLatin1String(" ") + wizard->displayCategory());
|
||||
categoryItem->setData(wizard->category(), Qt::UserRole);
|
||||
}
|
||||
|
||||
QStandardItem *wizardItem = new QStandardItem(wizard->displayName());
|
||||
QIcon wizardIcon;
|
||||
|
||||
// spacing hack. Add proper icons instead
|
||||
if (wizard->icon().isNull()) {
|
||||
wizardIcon = m_dummyIcon;
|
||||
} else {
|
||||
wizardIcon = wizard->icon();
|
||||
}
|
||||
wizardItem->setIcon(wizardIcon);
|
||||
wizardItem->setData(QVariant::fromValue(WizardContainer(wizard, 0)), Qt::UserRole);
|
||||
wizardItem->setFlags(Qt::ItemIsEnabled|Qt::ItemIsSelectable);
|
||||
categoryItem->appendRow(wizardItem);
|
||||
|
||||
}
|
||||
|
||||
void NewDialog::currentCategoryChanged(const QModelIndex &index)
|
||||
{
|
||||
if (index.parent() != m_model->invisibleRootItem()->index()) {
|
||||
m_ui->templatesView->setModel(m_model);
|
||||
m_ui->templatesView->setRootIndex(m_proxyModel->mapToSource(index));
|
||||
|
||||
m_ui->templatesView->setModel(m_filterProxyModel);
|
||||
QModelIndex sourceIndex = m_twoLevelProxyModel->mapToSource(index);
|
||||
sourceIndex = m_filterProxyModel->mapFromSource(sourceIndex);
|
||||
m_ui->templatesView->setRootIndex(sourceIndex);
|
||||
// Focus the first item by default
|
||||
m_ui->templatesView->setCurrentIndex(m_ui->templatesView->rootIndex().child(0,0));
|
||||
|
||||
@@ -342,11 +414,26 @@ void NewDialog::currentCategoryChanged(const QModelIndex &index)
|
||||
|
||||
void NewDialog::currentItemChanged(const QModelIndex &index)
|
||||
{
|
||||
QStandardItem* cat = m_model->itemFromIndex(index);
|
||||
if (const IWizard *wizard = wizardOfItem(cat))
|
||||
m_ui->templateDescription->setText(wizard->description());
|
||||
else
|
||||
QModelIndex sourceIndex = m_filterProxyModel->mapToSource(index);
|
||||
QStandardItem* cat = (m_model->itemFromIndex(sourceIndex));
|
||||
if (const IWizard *wizard = wizardOfItem(cat)) {
|
||||
QString desciption = wizard->description();
|
||||
if (!Qt::mightBeRichText(desciption))
|
||||
desciption.replace(QLatin1Char('\n'), QLatin1String("<br>"));
|
||||
desciption += QLatin1String("<br><br><b>");
|
||||
if (wizard->flags().testFlag(IWizard::PlatformIndependent))
|
||||
desciption += tr("Platform independent") + QLatin1String("</b>");
|
||||
else
|
||||
desciption += tr("Supported Platforms")
|
||||
+ QLatin1String("</b>: <tt>")
|
||||
+ wizard->supportedPlatforms().join(QLatin1String(" "))
|
||||
+ QLatin1String("</tt>");
|
||||
|
||||
m_ui->templateDescription->setHtml(desciption);
|
||||
|
||||
} else {
|
||||
m_ui->templateDescription->setText(QString());
|
||||
}
|
||||
updateOkButton();
|
||||
}
|
||||
|
||||
@@ -360,3 +447,9 @@ void NewDialog::updateOkButton()
|
||||
{
|
||||
m_okButton->setEnabled(currentWizard() != 0);
|
||||
}
|
||||
|
||||
void NewDialog::setSelectedPlatform(const QString & /*platform*/)
|
||||
{
|
||||
//The static cast allows us to keep PlatformFilterProxyModel anonymous
|
||||
static_cast<PlatformFilterProxyModel*>(m_filterProxyModel)->setPlatform(selectedPlatform());
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user