feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Clang: Limit the usage of qMakePair and std::make_pair

Browse Source 
Change-Id: Ida094760023047ecb8ba29e60d5e81f766981b65
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
Jarek Kobus
2022-09-30 14:11:20 +02:00
parent 93dc9ce591
commit 95e54055ef
8 changed files with 29 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/clangcodemodel/clangdmemoryusagewidget.cpp
View File

@@ -39,7 +39,7 @@ public:
for (auto it = obj.begin(); it != obj.end(); ++it) {
if (it.key() == totalKey() || it.key() == selfKey())
continue;
components << std::make_pair(MemoryTree(it.value()), it.key());
components.push_back({MemoryTree(it.value()), it.key()});
}
return components;
}
@@ -81,11 +81,9 @@ private:
QString memString() const
{
static const QList<std::pair<int, QString>> factors{
std::make_pair(1000000000, QString("GB")),
std::make_pair(1000000, QString("MB")),
std::make_pair(1000, QString("KB")),
};
static const QList<std::pair<int, QString>> factors{{1000000000, "GB"},
{1000000, "MB"},
{1000, "KB"}};
for (const auto &factor : factors) {
if (m_bytesUsed > factor.first)
return QString::number(qint64(std::round(double(m_bytesUsed) / factor.first)))