From 95e6dfe8e031255185905af36fb64fd62668475e Mon Sep 17 00:00:00 2001 From: Andre Hartmann Date: Wed, 8 Feb 2017 23:11:29 +0100 Subject: [PATCH] Git: BranchDialog: Disable buttons when selection disappears Steps to reproduce the old and wrong behavior: 1. Open branch dialog 2. Select a branch 3. Select checkout 4. Branch is checked out, but no longer selected 5. Buttons like "Log" stay enabled, but don't serve any purpose Change-Id: I3974b7cb87553d1ff57fd5578b908f02c949a509 Reviewed-by: Tobias Hunger --- src/plugins/git/branchdialog.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/plugins/git/branchdialog.cpp b/src/plugins/git/branchdialog.cpp index d38eb074000..a91153a20df 100644 --- a/src/plugins/git/branchdialog.cpp +++ b/src/plugins/git/branchdialog.cpp @@ -93,7 +93,7 @@ BranchDialog::BranchDialog(QWidget *parent) : connect(m_model, &QAbstractItemModel::rowsInserted, this, &BranchDialog::resizeColumns); connect(m_model, &QAbstractItemModel::rowsRemoved, this, &BranchDialog::resizeColumns); - enableButtons(); + m_ui->branchView->selectionModel()->clear(); } BranchDialog::~BranchDialog() @@ -258,7 +258,7 @@ void BranchDialog::checkout() else if (branchCheckoutDialog.popStashOfNextBranch()) client->synchronousStashRestore(m_repository, stashName, true); } - enableButtons(); + m_ui->branchView->selectionModel()->clear(); } /* Prompt to delete a local branch and do so. */ @@ -320,7 +320,7 @@ void BranchDialog::rename() m_model->renameBranch(oldName, branchAddDialog.branchName()); refreshCurrentRepository(); } - enableButtons(); + m_ui->branchView->selectionModel()->clear(); } void BranchDialog::diff()