Valgrind: Simplify suppression file interface

The global settings and per-project settings looked the same,
but behaved quite differently: The per-project one were a kind
of diff against the global one.

Besides having "issues" when keeping the temporary and permanent places
where relevant parts of the data were kept (settings, manual-applied
global, auto-applied local settings), the concept was not clear in the
UI at all.

This here takes the simple way out: Either local, or global, no diffs.

Change-Id: I90439cd20067ab60b88372f1cb03eeef8c2e42d3
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

src/plugins/valgrind/memchecktool.cpp

@@ -996,7 +996,8 @@ void MemcheckToolPrivate::setupRunner(MemcheckToolRunner *runTool)
 
     m_errorView->setDefaultSuppressionFile(dir + name + ".supp");
 
-    foreach (const QString &file, runTool->suppressionFiles()) {
+    const QStringList suppressionFiles = runTool->suppressionFiles();
+    for (const QString &file : suppressionFiles) {
         QAction *action = m_filterMenu->addAction(FilePath::fromString(file).fileName());
         action->setToolTip(file);
         connect(action, &QAction::triggered, this, [file] {