feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix crash when pressing '+' twice in Qt version settings.

Browse Source 
Bug was introduced when separating the version list into "Autodetected" and
"Manual" subtrees.
This commit is contained in:
con
2009-07-13 13:47:46 +02:00
parent d384e1a48f
commit 95fac2b096
2 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/plugins/qt4projectmanager/qtoptionspage.cpp
View File

@@ -370,6 +370,21 @@ int QtOptionsPageWidget::indexForTreeItem(QTreeWidgetItem *item) const
return -1;
}
QTreeWidgetItem *QtOptionsPageWidget::treeItemForIndex(int index) const
{
int uniqueId = m_versions.at(index)->uniqueId();
for (int i = 0; i < m_ui->qtdirList->topLevelItemCount(); ++i) {
QTreeWidgetItem *toplevelItem = m_ui->qtdirList->topLevelItem(i);
for (int j = 0; j < toplevelItem->childCount(); ++j) {
QTreeWidgetItem *item = toplevelItem->child(j);
if (item->data(0, Qt::UserRole).toInt() == uniqueId) {
return item;
}
}
}
return 0;
}
void QtOptionsPageWidget::versionChanged(QTreeWidgetItem *item, QTreeWidgetItem *old)
{
if (old) {
@@ -454,11 +469,11 @@ void QtOptionsPageWidget::fixQtVersionName(int index)
if (index < 0)
return;
int count = m_versions.count();
QString name = m_versions.at(index)->name();
for (int i = 0; i < count; ++i) {
if (i != index) {
if (m_versions.at(i)->name() == m_versions.at(index)->name()) {
// Same name, find new name
QString name = m_versions.at(index)->name();
QRegExp regexp("^(.*)\\((\\d)\\)$");
if (regexp.exactMatch(name)) {
// Alreay in Name (#) format
@@ -468,7 +483,7 @@ void QtOptionsPageWidget::fixQtVersionName(int index)
}
// set new name
m_versions[index]->setName(name);
m_ui->qtdirList->topLevelItem(index)->setText(0, name);
treeItemForIndex(index)->setText(0, name);
m_ui->defaultCombo->setItemText(index, name);
// Now check again...

1
src/plugins/qt4projectmanager/qtoptionspage.h
View File

@@ -61,6 +61,7 @@ private:
void fixQtVersionName(int index);
int indexForWidget(QWidget *debuggingHelperWidget) const;
int indexForTreeItem(QTreeWidgetItem *item) const;
QTreeWidgetItem *treeItemForIndex(int index) const;
Internal::Ui::QtVersionManager *m_ui;
QList<QtVersion *> m_versions;