From 95ff7a6c80c6f9e7edef1710771d40ba399842bf Mon Sep 17 00:00:00 2001
From: Christian Stenger <christian.stenger@qt.io>
Date: Fri, 28 May 2021 09:56:24 +0200
Subject: [PATCH] LSP: Fix logic to avoid nullptr access

Change-Id: I5511d266b52b1bc1763bdf3cd430f49f30ae3f37
Reviewed-by: David Schulz <david.schulz@qt.io>
---
 src/libs/languageserverprotocol/completion.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/libs/languageserverprotocol/completion.cpp b/src/libs/languageserverprotocol/completion.cpp
index ca34629805a..faeb2377180 100644
--- a/src/libs/languageserverprotocol/completion.cpp
+++ b/src/libs/languageserverprotocol/completion.cpp
@@ -45,8 +45,9 @@ Utils::optional<MarkupOrString> CompletionItem::documentation() const
 Utils::optional<CompletionItem::InsertTextFormat> CompletionItem::insertTextFormat() const
 {
     Utils::optional<int> value = optionalValue<int>(insertTextFormatKey);
-    return value.has_value() ? Utils::nullopt
-            : Utils::make_optional(CompletionItem::InsertTextFormat(value.value()));
+    return value.has_value()
+            ? Utils::make_optional(CompletionItem::InsertTextFormat(value.value()))
+            : Utils::nullopt;
 }
 
 bool CompletionItem::isValid(ErrorHierarchy *error) const