From 9635b1545b8f0946b0206f96c24ce52ab4e881c0 Mon Sep 17 00:00:00 2001
From: hjk <hjk@qt.io>
Date: Mon, 21 Nov 2022 11:02:49 +0100
Subject: [PATCH] CMakeManager: Avoid one use of
 Environment::appendExeExtensions()

Use FilePath::refersToExecutableFile() instead.

This makes it better re-usable for remote setup.

Change-Id: Ic69739b332f036ed791adbbc8092a139b4c83c2d
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
---
 .../cmakeprojectmanager/cmaketoolsettingsaccessor.cpp | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/src/plugins/cmakeprojectmanager/cmaketoolsettingsaccessor.cpp b/src/plugins/cmakeprojectmanager/cmaketoolsettingsaccessor.cpp
index 362c62c7b1f..a92454e169c 100644
--- a/src/plugins/cmakeprojectmanager/cmaketoolsettingsaccessor.cpp
+++ b/src/plugins/cmakeprojectmanager/cmaketoolsettingsaccessor.cpp
@@ -65,18 +65,13 @@ static std::vector<std::unique_ptr<CMakeTool>> autoDetectCMakeTools()
         path.append("/opt/local/bin");
     }
 
-    const QStringList execs = env.appendExeExtensions(QLatin1String("cmake"));
-
     FilePaths suspects;
     for (const FilePath &base : std::as_const(path)) {
         if (base.isEmpty())
             continue;
-
-        for (const QString &exec : execs) {
-            const FilePath suspect = base.resolvePath(exec);
-            if (suspect.isExecutableFile())
-                suspects << suspect;
-        }
+        const FilePath suspect = base / "cmake";
+        if (suspect.refersToExecutableFile(FilePath::WithAnySuffix))
+            suspects << suspect;
     }
 
     std::vector<std::unique_ptr<CMakeTool>> found;