feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix deadlock in .pro file evaluation.

Browse Source 
We used to indicate that the cache for a file is up to date by having a
Entry with ent->locker == 0. But we first wake up all threads and only
after all the threads who waited for that parse to complete we set
ent->locker to zero. Thus a different thread could get the impression
that it needs to wait for the parse thread, yet get no wake up.

We need a different flag to indicate that we are actually already done
parsing and the cache can simply be used instead of waiting for a wake
up.

Reviewed-By: ossi
This commit is contained in:
dt
2010-03-17 16:19:55 +01:00
parent b6fda5be84
commit 9663067357
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/shared/proparser/profileevaluator.cpp
View File

@@ -3031,7 +3031,7 @@ ProFile *ProFileEvaluator::Private::parsedProFile(const QString &fileName, bool
if (it != m_option->cache->parsed_files.end()) { if (it != m_option->cache->parsed_files.end()) {
ent = &*it; ent = &*it;
#ifdef PROPARSER_THREAD_SAFE #ifdef PROPARSER_THREAD_SAFE
if (ent->locker) { if (ent->locker && !ent->locker->done) {
++ent->locker->waiters; ++ent->locker->waiters;
QThreadPool::globalInstance()->releaseThread(); QThreadPool::globalInstance()->releaseThread();
ent->locker->cond.wait(locker.mutex()); ent->locker->cond.wait(locker.mutex());
@@ -3061,6 +3061,7 @@ ProFile *ProFileEvaluator::Private::parsedProFile(const QString &fileName, bool
#ifdef PROPARSER_THREAD_SAFE #ifdef PROPARSER_THREAD_SAFE
locker.relock(); locker.relock();
if (ent->locker->waiters) { if (ent->locker->waiters) {
ent->locker->done = true;
ent->locker->cond.wakeAll(); ent->locker->cond.wakeAll();
} else { } else {
delete ent->locker; delete ent->locker;

3
src/shared/proparser/profileevaluator.h
View File

@@ -123,9 +123,10 @@ private:
ProFile *pro; ProFile *pro;
#ifdef PROPARSER_THREAD_SAFE #ifdef PROPARSER_THREAD_SAFE
struct Locker { struct Locker {
Locker() : waiters(0) {} Locker() : waiters(0), done(false) {}
QWaitCondition cond; QWaitCondition cond;
int waiters; int waiters;
bool done;
}; };
Locker *locker; Locker *locker;
#endif #endif