feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

SynchronousProcess: Change exit code interpreter to function object

Browse Source 
Change-Id: Ic48d4f5810f171c070f0980581fb6e45f6fe6b4a
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
Eike Ziller
2016-04-25 14:40:42 +02:00
parent cb08a44e7e
commit 967177d3d8
14 changed files with 54 additions and 126 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/vcsbase/vcsbaseclient.h
View File

@@ -28,6 +28,7 @@
#include "vcsbase_global.h"
#include <utils/fileutils.h>
#include <utils/synchronousprocess.h>
#include <QObject>
#include <QStringList>
@@ -42,11 +43,6 @@ QT_END_NAMESPACE
namespace Core { class Id; }
namespace Utils {
struct SynchronousProcessResponse;
class ExitCodeInterpreter;
} // namespace Utils
namespace VcsBase {
class VcsCommand;
@@ -86,7 +82,7 @@ public:
void enqueueJob(VcsCommand *cmd, const QStringList &args,
const QString &workingDirectory = QString(),
Utils::ExitCodeInterpreter *interpreter = 0);
const Utils::ExitCodeInterpreter &interpreter = Utils::defaultExitCodeInterpreter);
virtual QProcessEnvironment processEnvironment() const;
@@ -220,7 +216,7 @@ protected:
};
virtual QString vcsCommandString(VcsCommandTag cmd) const;
virtual Core::Id vcsEditorKind(VcsCommandTag cmd) const = 0;
virtual Utils::ExitCodeInterpreter *exitCodeInterpreter(VcsCommandTag cmd, QObject *parent) const;
virtual Utils::ExitCodeInterpreter exitCodeInterpreter(VcsCommandTag cmd) const;
virtual QStringList revisionSpec(const QString &revision) const = 0;